Re: [PATCH]rt73usb: fix for master mode.

[Alexandre Becholey <alexandre@shockfish.com>]

Ivo van Doorn wrote:
> On Monday 18 May 2009, Alexandre Becholey wrote:
>   
>> Report status unknown as if there were successfully transmitted.
>> This will avoid hostapd to disassociate because it doesn't understand what a status unknown is.
>>
>> Signed-off-by: Alexandre Becholey <alexandre.becholey@epfl.ch>
>> ---
>>  drivers/net/wireless/rt2x00/rt2x00dev.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>     
>
> Please put your patches inline, and CC me for rt2x00 related patches.
>   
Yep sorry I forgot to CC you :-/
Oups I forgot an --inline in the git-format-patch
> As for the patch it seems like you indented with spaces rather then tabs?
>   
Sorry first time I submitted a patch... I use vim and I use tabs that's 
strange.
I'll restart from the original file.

> And please put the comment inside the else statement rather then breaking
> the if-elseif-elseif list.
>
> Also have you considered the following things:
> 	RTS frames success/failure reporting?
> 	tx_success/tx_failure statistics counters (used in link_tuner as well)
>
> Thanks,
>
> Ivo
>   
Ok I'll do it, but how should I treat the status unknown for the 
statistics? as a success?

Alexandre