linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] rfkill: always init poll delayed work
Date: Wed, 03 Jun 2009 09:50:20 -0500	[thread overview]
Message-ID: <4A268DAC.4010805@lwfinger.net> (raw)
In-Reply-To: <1244015729.7176.28.camel@johannes.local>

Johannes Berg wrote:
> The rfkill core didn't initialise the poll delayed work
> because it assumed that polling was always done by specifying
> the poll function. cfg80211, however, would like to start
> polling only later, which is a valid use case and easy to
> support, so change rfkill to always initialise the poll
> delayed work and thus allow starting polling by calling the
> rfkill_resume_polling() function after registration.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---

This patch fixed to kernel BUG_ON, but there are still problems. This
has been tested with b43.

1. A minor one - the radio LED switch never comes on. Module led-class
is loaded.

2. Much more serious - When the radio kill switch is turned off, the
radio is killed just as expected, but it is not restored when the
switch is turned on. The only way to restore the radio is to
rmmod/insmod b43. Similarly, if the module is loaded with the switch
off, it is not possible to turn the radio on. An unload/load resquence
is then needed.

Larry


  reply	other threads:[~2009-06-03 14:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-03  7:55 [PATCH] rfkill: always init poll delayed work Johannes Berg
2009-06-03 14:50 ` Larry Finger [this message]
2009-06-03 14:55   ` Johannes Berg
2009-06-04 14:52     ` Larry Finger
2009-06-04 15:12       ` Johannes Berg
2009-06-04 15:59         ` Larry Finger
2009-06-04 16:19           ` Johannes Berg
2009-06-04 16:28             ` Larry Finger
2009-06-04 16:31               ` Johannes Berg
2009-06-04 16:51                 ` Larry Finger
2009-06-04 16:57                   ` Johannes Berg
2009-06-04 17:52                     ` Larry Finger
2009-06-04 18:02                       ` Johannes Berg
2009-06-05 13:03                         ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A268DAC.4010805@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).