Re: [PATCH] rfkill: create useful userspace interface

[Alan Jenkins <alan-jenkins@tuffmail.co.uk>]

Johannes Berg wrote:
> On Sun, 2009-06-07 at 09:57 -0300, Henrique de Moraes Holschuh wrote:
>
>   
>>>  1) remove rfkill_set_global_sw_state()
>>>  2) rfkill devices with NVS can e.g. call rfkill_has_nvs() before
>>> registration, setting a flag.
>>>  3) the "has NVS" flag is reported by /dev/rfkill, (at least in ADD
>>> events, tho it may as well be set in all events)
>>>  4) rfkill-input preserves existing behaviour - *if enabled* - by
>>> initializing the global state from individual devices which have NVS.
>>> (As before, each _type_ of rfkill device has its own global state).
>>>  5) rfkill devices with NVS will have their current state preserved,
>>> so long as the global state has not yet been set (by userspace or by
>>> rfkill-input).  Of course userspace can change the state in response
>>> to the device being added.
>>>       
>
>   
>> Let's do it :-)
>>     
>
>
> Alan, you're right in that we currently overwrite devices with the
> global state upon registration. My suggestion would be to not do that
> when set_sw_state() has been called on the device before it was
> registered, by simply keeping track of that. Anyone want to propose a
> patch?
>
> johannes
>   

I'll have a go.  It seems within my abilities and I have hardware to
test it on.  What could possibly go wrong :-).

I'll try to do it in one swoop, get rid of set_global_sw_state() and
convert tp-acpi as well as eeepc-laptop.

Thanks
Alan