From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Bob Copeland <me@bobcopeland.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-pm@lists.linux-foundation.org,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
ath5k-devel@venema.h4ckr.net, linux-pci@vger.kernel.org
Subject: Re: [ath5k-devel] [linux-pm] PCI hotplug v.s. suspend
Date: Fri, 19 Jun 2009 09:34:20 +0100 [thread overview]
Message-ID: <4A3B4D8C.6010002@tuffmail.co.uk> (raw)
In-Reply-To: <4A3AAF0A.9020707@tuffmail.co.uk>
Alan Jenkins wrote:
> Alan Stern wrote:
>
>> On Thu, 18 Jun 2009, Alan Jenkins wrote:
>>
>>
>>
>>> Unfortunately this makes it worse. My eeepc-laptop hacks are now in
>>> wireless-testing. If I apply the above patch to wireless-testing and
>>> "remove" the device while suspended, I get a soft hang on resume.
>>>
>>>
>> Is this different from the behavior without the patch? (I don't see
>> how it could be.)
>>
>>
>
> Ow. No, the free_irq patch doesn't cause this bug. I missed testing
> this case after adding a workaround for an even more obscure issue :-(.
>
I tried an earlier version without the problem workaround. Bob's
suggested patch to remove the free_irq() on suspend works fine. It
fixes the WARNING when the device is removed during suspend, and it
still works if the device is not removed during suspend.
Alan
next prev parent reply other threads:[~2009-06-19 8:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 10:55 PCI hotplug v.s. suspend Alan Jenkins
2009-06-15 13:58 ` [linux-pm] " Alan Stern
2009-06-15 14:03 ` Alan Jenkins
2009-06-15 14:37 ` Alan Stern
2009-06-15 19:58 ` Rafael J. Wysocki
2009-06-15 20:34 ` Alan Stern
2009-06-15 20:51 ` Rafael J. Wysocki
2009-06-16 1:01 ` [ath5k-devel] " Bob Copeland
2009-06-18 11:51 ` Alan Jenkins
2009-06-18 18:45 ` Alan Stern
2009-06-18 21:18 ` Alan Jenkins
2009-06-19 8:34 ` Alan Jenkins [this message]
2009-06-19 11:08 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3B4D8C.6010002@tuffmail.co.uk \
--to=alan-jenkins@tuffmail.co.uk \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).