* [PATCH V2] ssb: Add support for 4318E
@ 2009-07-01 3:39 Larry Finger
2009-07-01 13:17 ` Michael Buesch
0 siblings, 1 reply; 4+ messages in thread
From: Larry Finger @ 2009-07-01 3:39 UTC (permalink / raw)
To: John W Linville, Michael Buesch, ccmcphe; +Cc: bcm43xx-dev, linux-wireless
From: Clyde McPherson <ccmcphe@verizon.net>
Added support for the Broadcom 4318E chipset on PCMCIA/CF cards. The
4318E can do 802.11A/B/G, only B and G mode are supported in b43.
Signed-off-by: Clyde McPherson <ccmcphe@verizon.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Index: wireless-testing/drivers/ssb/pcmcia.c
===================================================================
--- wireless-testing.orig/drivers/ssb/pcmcia.c
+++ wireless-testing/drivers/ssb/pcmcia.c
@@ -678,7 +678,8 @@ int ssb_pcmcia_get_invariants(struct ssb
sprom->board_rev = tuple.TupleData[1];
break;
case SSB_PCMCIA_CIS_PA:
- GOTO_ERROR_ON(tuple.TupleDataLen != 9,
+ GOTO_ERROR_ON((tuple.TupleDataLen != 9) &&
+ (tuple.TupleDataLen != 10),
"pa tpl size");
sprom->pa0b0 = tuple.TupleData[1] |
((u16)tuple.TupleData[2] << 8);
@@ -718,7 +719,8 @@ int ssb_pcmcia_get_invariants(struct ssb
sprom->antenna_gain.ghz5.a3 = tuple.TupleData[1];
break;
case SSB_PCMCIA_CIS_BFLAGS:
- GOTO_ERROR_ON(tuple.TupleDataLen != 3,
+ GOTO_ERROR_ON((tuple.TupleDataLen != 3) &&
+ (tuple.TupleDataLen != 5),
"bfl tpl size");
sprom->boardflags_lo = tuple.TupleData[1] |
((u16)tuple.TupleData[2] << 8);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] ssb: Add support for 4318E
2009-07-01 3:39 [PATCH V2] ssb: Add support for 4318E Larry Finger
@ 2009-07-01 13:17 ` Michael Buesch
2009-07-01 15:28 ` Larry Finger
0 siblings, 1 reply; 4+ messages in thread
From: Michael Buesch @ 2009-07-01 13:17 UTC (permalink / raw)
To: Larry Finger; +Cc: John W Linville, ccmcphe, bcm43xx-dev, linux-wireless
On Wednesday 01 July 2009 05:39:43 Larry Finger wrote:
> From: Clyde McPherson <ccmcphe@verizon.net>
>
> Added support for the Broadcom 4318E chipset on PCMCIA/CF cards. The
> 4318E can do 802.11A/B/G, only B and G mode are supported in b43.
>
> Signed-off-by: Clyde McPherson <ccmcphe@verizon.net>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
ack
> ---
>
> Index: wireless-testing/drivers/ssb/pcmcia.c
> ===================================================================
> --- wireless-testing.orig/drivers/ssb/pcmcia.c
> +++ wireless-testing/drivers/ssb/pcmcia.c
> @@ -678,7 +678,8 @@ int ssb_pcmcia_get_invariants(struct ssb
> sprom->board_rev = tuple.TupleData[1];
> break;
> case SSB_PCMCIA_CIS_PA:
> - GOTO_ERROR_ON(tuple.TupleDataLen != 9,
> + GOTO_ERROR_ON((tuple.TupleDataLen != 9) &&
> + (tuple.TupleDataLen != 10),
> "pa tpl size");
> sprom->pa0b0 = tuple.TupleData[1] |
> ((u16)tuple.TupleData[2] << 8);
> @@ -718,7 +719,8 @@ int ssb_pcmcia_get_invariants(struct ssb
> sprom->antenna_gain.ghz5.a3 = tuple.TupleData[1];
> break;
> case SSB_PCMCIA_CIS_BFLAGS:
> - GOTO_ERROR_ON(tuple.TupleDataLen != 3,
> + GOTO_ERROR_ON((tuple.TupleDataLen != 3) &&
> + (tuple.TupleDataLen != 5),
> "bfl tpl size");
> sprom->boardflags_lo = tuple.TupleData[1] |
> ((u16)tuple.TupleData[2] << 8);
>
>
--
Greetings, Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] ssb: Add support for 4318E
2009-07-01 13:17 ` Michael Buesch
@ 2009-07-01 15:28 ` Larry Finger
2009-07-01 18:18 ` Michael Buesch
0 siblings, 1 reply; 4+ messages in thread
From: Larry Finger @ 2009-07-01 15:28 UTC (permalink / raw)
To: John W Linville; +Cc: bcm43xx-dev, linux-wireless
Michael Buesch wrote:
> On Wednesday 01 July 2009 05:39:43 Larry Finger wrote:
>> From: Clyde McPherson <ccmcphe@verizon.net>
>>
>> Added support for the Broadcom 4318E chipset on PCMCIA/CF cards. The
>> 4318E can do 802.11A/B/G, only B and G mode are supported in b43.
>>
>> Signed-off-by: Clyde McPherson <ccmcphe@verizon.net>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> ack
>
Cc: Stable <stable@vger.kernel.org>
John,
I forgot the above line in both the b43 and ssb patches.
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] ssb: Add support for 4318E
2009-07-01 15:28 ` Larry Finger
@ 2009-07-01 18:18 ` Michael Buesch
0 siblings, 0 replies; 4+ messages in thread
From: Michael Buesch @ 2009-07-01 18:18 UTC (permalink / raw)
To: bcm43xx-dev; +Cc: Larry Finger, John W Linville, linux-wireless
On Wednesday 01 July 2009 17:28:43 Larry Finger wrote:
> Michael Buesch wrote:
> > On Wednesday 01 July 2009 05:39:43 Larry Finger wrote:
> >> From: Clyde McPherson <ccmcphe@verizon.net>
> >>
> >> Added support for the Broadcom 4318E chipset on PCMCIA/CF cards. The
> >> 4318E can do 802.11A/B/G, only B and G mode are supported in b43.
> >>
> >> Signed-off-by: Clyde McPherson <ccmcphe@verizon.net>
> >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> >
> > ack
> >
>
> Cc: Stable <stable@vger.kernel.org>
I do not think these patches are subject to -stable.
--
Greetings, Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-07-01 18:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-01 3:39 [PATCH V2] ssb: Add support for 4318E Larry Finger
2009-07-01 13:17 ` Michael Buesch
2009-07-01 15:28 ` Larry Finger
2009-07-01 18:18 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).