From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Larry Finger <larry.finger@gmail.com>,
Hin-Tak Leung <hintak.leung@gmail.com>,
Hin-Tak Leung <htl10@users.sourceforge.net>,
Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Subject: Re: [Bisected][Regression] Oops/panic when rmmoding rtl8187 on SMP since commit "rtl8187: Implement TX/RX blink for LED"
Date: Sun, 12 Jul 2009 15:25:14 -0500 [thread overview]
Message-ID: <4A5A46AA.5070605@lwfinger.net> (raw)
In-Reply-To: <69e28c910907121311g2011c960g141bd35891c8ea25@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
Gábor Stefanik wrote:
> I'm getting a kernel oops/panic when unloading rtl8187. Bisect lead me
> to commit "rtl8187: Implement TX/RX blink for LED", confirmed by local
> backout.
> My card is an RTL8187LvB, "Customer ID 0x00" (P5K Premium integrated
> WiFi, made by Azurewave).
Does this patch fix it?
Larry
---
Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8187_leds.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8187_leds.c
+++ wireless-testing/drivers/net/wireless/rtl818x/rtl8187_leds.c
@@ -212,6 +212,7 @@ void rtl8187_leds_exit(struct ieee80211_
/* turn the LED off before exiting */
queue_delayed_work(dev->workqueue, &priv->led_off, 0);
cancel_delayed_work_sync(&priv->led_off);
+ cancel_delayed_work_sync(&priv->led_on);
rtl8187_unregister_led(&priv->led_rx);
}
#endif /* def CONFIG_RTL8187_LED */
[-- Attachment #2: rtl8187_fix_led_exit --]
[-- Type: text/plain, Size: 598 bytes --]
Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8187_leds.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8187_leds.c
+++ wireless-testing/drivers/net/wireless/rtl818x/rtl8187_leds.c
@@ -212,6 +212,7 @@ void rtl8187_leds_exit(struct ieee80211_
/* turn the LED off before exiting */
queue_delayed_work(dev->workqueue, &priv->led_off, 0);
cancel_delayed_work_sync(&priv->led_off);
+ cancel_delayed_work_sync(&priv->led_on);
rtl8187_unregister_led(&priv->led_rx);
}
#endif /* def CONFIG_RTL8187_LED */
prev parent reply other threads:[~2009-07-12 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-12 20:11 [Bisected][Regression] Oops/panic when rmmoding rtl8187 on SMP since commit "rtl8187: Implement TX/RX blink for LED" Gábor Stefanik
2009-07-12 20:25 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5A46AA.5070605@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=herton@mandriva.com.br \
--cc=hintak.leung@gmail.com \
--cc=htl10@users.sourceforge.net \
--cc=larry.finger@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox