From: Roel Kluin <roel.kluin@gmail.com>
To: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] arlan: inverted logic?
Date: Mon, 13 Jul 2009 00:10:07 +0200 [thread overview]
Message-ID: <4A5A5F3F.80100@gmail.com> (raw)
Inverted logic
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Usually the inverted occurs see:
s="[[:space:]]*"
em='!'
git grep -E -n -A1 "if$s\($s$em?${s}netif_running$s\(" |
grep -B1 "[-]EBUSY" | less
Is my patch correct? please review.
diff --git a/drivers/net/wireless/arlan-main.c b/drivers/net/wireless/arlan-main.c
index d84caf1..4ac519f 100644
--- a/drivers/net/wireless/arlan-main.c
+++ b/drivers/net/wireless/arlan-main.c
@@ -1022,7 +1022,7 @@ static int arlan_mac_addr(struct net_device *dev, void *p)
ARLAN_DEBUG_ENTRY("arlan_mac_addr");
return -EINVAL;
- if (!netif_running(dev))
+ if (netif_running(dev))
return -EBUSY;
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
reply other threads:[~2009-07-12 22:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5A5F3F.80100@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).