* [PATCH] arlan: inverted logic?
@ 2009-07-12 22:10 Roel Kluin
0 siblings, 0 replies; only message in thread
From: Roel Kluin @ 2009-07-12 22:10 UTC (permalink / raw)
To: linville, linux-wireless, Andrew Morton
Inverted logic
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Usually the inverted occurs see:
s="[[:space:]]*"
em='!'
git grep -E -n -A1 "if$s\($s$em?${s}netif_running$s\(" |
grep -B1 "[-]EBUSY" | less
Is my patch correct? please review.
diff --git a/drivers/net/wireless/arlan-main.c b/drivers/net/wireless/arlan-main.c
index d84caf1..4ac519f 100644
--- a/drivers/net/wireless/arlan-main.c
+++ b/drivers/net/wireless/arlan-main.c
@@ -1022,7 +1022,7 @@ static int arlan_mac_addr(struct net_device *dev, void *p)
ARLAN_DEBUG_ENTRY("arlan_mac_addr");
return -EINVAL;
- if (!netif_running(dev))
+ if (netif_running(dev))
return -EBUSY;
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-07-12 22:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-12 22:10 [PATCH] arlan: inverted logic? Roel Kluin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).