From: Jiri Slaby <jirislaby@gmail.com>
To: reinette chatre <reinette.chatre@intel.com>
Cc: "Zhu, Yi" <yi.zhu@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ipw3945-devel@lists.sourceforge.net"
<ipw3945-devel@lists.sourceforge.net>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: iwl: potential deadlock?
Date: Mon, 13 Jul 2009 22:33:01 +0200 [thread overview]
Message-ID: <4A5B99FD.5030505@gmail.com> (raw)
In-Reply-To: <1247516320.17896.1640.camel@rc-desk>
On 07/13/2009 10:18 PM, reinette chatre wrote:
> On Mon, 2009-07-13 at 12:34 -0700, Jiri Slaby wrote:
>> we found a potential deadlock in iwl code by our tool.
>
> What tool is this?
It's called stanse[1], we still work on it.
>> iwl_update_tkip_key()
>> -> spin_lock_irqsave(&priv->sta_lock)
>> -> iwl_send_add_sta()
>
> iwl_send_add_sta() is called here with flags = CMD_ASYNC
>
> In iwl_send_add_sta() we have:
> if (ret || (flags & CMD_ASYNC))
> return ret;
Yes, you're right, indeed. Thanks for the explanation.
[1] http://iti.fi.muni.cz/stanse/
prev parent reply other threads:[~2009-07-13 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 19:34 iwl: potential deadlock? Jiri Slaby
2009-07-13 20:18 ` reinette chatre
2009-07-13 20:33 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5B99FD.5030505@gmail.com \
--to=jirislaby@gmail.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).