From: Daniel Drake <dsd@gentoo.org>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: wireless drivers sparse warnings 07-24
Date: Sun, 26 Jul 2009 15:41:04 +0545 [thread overview]
Message-ID: <4A6C2834.2010906@gentoo.org> (raw)
In-Reply-To: <43e72e890907240922q3d7c9f0agfc8479008f9ba959@mail.gmail.com>
Luis R. Rodriguez wrote:
> CHECK drivers/net/wireless/zd1211rw/zd_usb.c
> drivers/net/wireless/zd1211rw/zd_usb.c:367:24: warning: implicit cast
> from nocast type
>
> I last tried to address this last one with Dan but I forget where we ended up.
I suggested that you avoid using a constant designed for register usage
here because you are not dealing with register addresses (it is just a
coincidence, perhaps intentional, that it is the same value as a related
register address). i.e. change CR_INTERRUPT to 0x9510 or a new constant.
Daniel
prev parent reply other threads:[~2009-07-26 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 16:22 wireless drivers sparse warnings 07-24 Luis R. Rodriguez
2009-07-26 9:56 ` Daniel Drake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6C2834.2010906@gentoo.org \
--to=dsd@gentoo.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).