Re: Problem with exclusive interrupt in hostap_cs

[Wolfram Sang <w.sang@pengutronix.de>]

Hi Larry,

Larry Finger wrote:

> I took a second look at the code and found that other drivers are using the
> routine prism2_interrupt() with shared interrupts, thus the patch below should
> be all that is needed.
> 
> I trust that you will be able to build the patched driver.
> 
> Larry
> 
> 
> Index: wireless-testing/drivers/net/wireless/hostap/hostap_cs.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/hostap/hostap_cs.c
> +++ wireless-testing/drivers/net/wireless/hostap/hostap_cs.c
> @@ -666,7 +666,8 @@ static int prism2_config(struct pcmcia_d
>  	 * irq structure is initialized.
>  	 */
>  	if (link->conf.Attributes & CONF_ENABLE_IRQ) {
> -		link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
> +		link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING |
> +				       IRQ_HANDLE_PRESENT;
>  		link->irq.IRQInfo1 = IRQ_LEVEL_ID;
>  		link->irq.Handler = prism2_interrupt;
>  		link->irq.Instance = dev;

Do you think this could be queued up by now? Looks okay to me...

Regards,

    Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |