From: Larry Finger <Larry.Finger@lwfinger.net>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-pcmcia@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: Problem with exclusive interrupt in hostap_cs
Date: Mon, 27 Jul 2009 17:28:34 -0500 [thread overview]
Message-ID: <4A6E2A12.30009@lwfinger.net> (raw)
In-Reply-To: <4A6DB08F.2060108@pengutronix.de>
Wolfram Sang wrote:
> Hi Larry,
>
> Larry Finger wrote:
>
>> I took a second look at the code and found that other drivers are
>> using the
>> routine prism2_interrupt() with shared interrupts, thus the patch
>> below should
>> be all that is needed.
>>
>> I trust that you will be able to build the patched driver.
>>
>> Larry
>>
>>
>> Index: wireless-testing/drivers/net/wireless/hostap/hostap_cs.c
>> ===================================================================
>> --- wireless-testing.orig/drivers/net/wireless/hostap/hostap_cs.c
>> +++ wireless-testing/drivers/net/wireless/hostap/hostap_cs.c
>> @@ -666,7 +666,8 @@ static int prism2_config(struct pcmcia_d
>> * irq structure is initialized.
>> */
>> if (link->conf.Attributes & CONF_ENABLE_IRQ) {
>> - link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
>> + link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING |
>> + IRQ_HANDLE_PRESENT;
>> link->irq.IRQInfo1 = IRQ_LEVEL_ID;
>> link->irq.Handler = prism2_interrupt;
>> link->irq.Instance = dev;
>
> Do you think this could be queued up by now? Looks okay to me...
As Dominik was missing and there was no action on the linux-pcmcia
list, I took advantage of the fact that this is a wireless device and
submitted the patch to John Linville. It is commit
e4a01604b8e5656f3a059f52b3e8f2560740c057 in the wireless-testing tree
and was sent to DaveM on July 24 for linux-next. It will be in 2.6.32.
Larry
next prev parent reply other threads:[~2009-07-27 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090420101340.142b6bc6@dp-indexing.com>
2009-04-20 19:19 ` Problem with exclusive interrupt in hostap_cs Larry Finger
2009-04-20 22:57 ` Peter Stuge
[not found] ` <20090421103617.05737b01@dp-indexing.com>
2009-04-21 16:49 ` Larry Finger
2009-07-27 13:50 ` Wolfram Sang
2009-07-27 22:28 ` Larry Finger [this message]
2009-07-28 8:34 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6E2A12.30009@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).