From: Dave <kilroyd@googlemail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Holger Schurig <hs4233@mail.mn-solutions.de>,
linux-wireless@vger.kernel.org, Pavel Roskin <proski@gnu.org>,
orinoco-devel@lists.sourceforge.net,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] orinoco: enable cfg80211 "set_channel" operation
Date: Tue, 28 Jul 2009 21:42:30 +0100 [thread overview]
Message-ID: <4A6F62B6.5060902@gmail.com> (raw)
In-Reply-To: <1248798699.13742.3.camel@johannes.local>
Johannes Berg wrote:
> On Tue, 2009-07-28 at 18:29 +0200, Johannes Berg wrote:
>> On Tue, 2009-07-28 at 17:27 +0100, Dave wrote:
>>
>>> Looks right for monitor mode (as you tested), but for ad-hoc the channel
>>> change would be delayed until the next SIOCSIWCOMMIT. Which for cfg80211
>>> is currently only on change_vif.
>> You won't be getting this call for ad-hoc mode, because then the channel
>> is contained in the ibss_join() parameters.
>
>
>>> You can also eliminate orinoco_ioctl_setfreq from wext.c with this
>>> change.
>
> That also means you can't eliminate that, of course, since for connect()
> the channels is also contained in the parameters, and the set_freq isn't
> invoked.
Ah. Thanks for the corrections.
Dave.
next prev parent reply other threads:[~2009-07-28 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200907281634.26104.hs4233@mail.mn-solutions.de>
2009-07-28 16:27 ` [PATCH] orinoco: enable cfg80211 "set_channel" operation Dave
2009-07-28 16:29 ` Johannes Berg
2009-07-28 16:31 ` Johannes Berg
2009-07-28 20:42 ` Dave [this message]
2009-07-29 7:16 ` Holger Schurig
2009-07-30 18:47 ` Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6F62B6.5060902@gmail.com \
--to=kilroyd@googlemail.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=orinoco-devel@lists.sourceforge.net \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).