From: Dave <kilroyd@googlemail.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: linux-wireless@vger.kernel.org, Pavel Roskin <proski@gnu.org>,
orinoco-devel@lists.sourceforge.net,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] orinoco: enable cfg80211 "set_channel" operation
Date: Thu, 30 Jul 2009 19:47:11 +0100 [thread overview]
Message-ID: <4A71EAAF.1050706@gmail.com> (raw)
In-Reply-To: <200907290916.31603.hs4233@mail.mn-solutions.de>
Holger Schurig wrote:
> On Tuesday 28 July 2009 18:27:54 Dave wrote:
>> You can also eliminate orinoco_ioctl_setfreq from wext.c with
>> this change.
>
> You mean this ?!?
Yes, except:
> @@ -1481,7 +1432,6 @@
> static const iw_handler orinoco_handler[] = {
> STD_IW_HANDLER(SIOCSIWCOMMIT, orinoco_ioctl_commit),
> STD_IW_HANDLER(SIOCGIWNAME, cfg80211_wext_giwname),
> - STD_IW_HANDLER(SIOCSIWFREQ, orinoco_ioctl_setfreq),
+ STD_IW_HANDLER(SIOCSIWFREQ, cfg80211_wext_setfreq ish),
> STD_IW_HANDLER(SIOCGIWFREQ, orinoco_ioctl_getfreq),
> STD_IW_HANDLER(SIOCSIWMODE, cfg80211_wext_siwmode),
> STD_IW_HANDLER(SIOCGIWMODE, cfg80211_wext_giwmode),
>
> I tried, but with then an "iwconfig eth1 channel 1" gave me an
> error. I did not investigate this further.
And as Johannes pointed out, we need to have the non-cfg80211 version so
adhoc connections can still be made via wext.
So the original patch is fine as is. Ack from me.
Dave.
prev parent reply other threads:[~2009-07-30 18:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200907281634.26104.hs4233@mail.mn-solutions.de>
2009-07-28 16:27 ` [PATCH] orinoco: enable cfg80211 "set_channel" operation Dave
2009-07-28 16:29 ` Johannes Berg
2009-07-28 16:31 ` Johannes Berg
2009-07-28 20:42 ` Dave
2009-07-29 7:16 ` Holger Schurig
2009-07-30 18:47 ` Dave [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A71EAAF.1050706@gmail.com \
--to=kilroyd@googlemail.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=orinoco-devel@lists.sourceforge.net \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).