wpa_test not used in wpa.c

wpa_test not used in wpa.c

[Ben Greear]

It seems to me that in this method (and others), wpa_test is not
actually assigned a useful value, but it's still tested in code
branches.


ieee80211_txrx_result
ieee80211_rx_h_michael_mic_verify(struct ieee80211_txrx_data *rx)


In this one, it seems to always force a code branch to happen:

ieee80211_txrx_result
ieee80211_tx_h_michael_mic_add(struct ieee80211_txrx_data *tx)


Any idea on how this is supposed to work?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Re: wpa_test not used in wpa.c

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

On Fri, 2009-07-31 at 14:42 -0700, Ben Greear wrote:
> It seems to me that in this method (and others), wpa_test is not
> actually assigned a useful value, but it's still tested in code
> branches.

> 
> Any idea on how this is supposed to work?

It isn't really. It's some dead code that you can enable manually for
testing or so. It used to be possible to use a private ioctl or so to
set it, iirc, but that's long gone. I'd have no objections to just
removing it.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: wpa_test not used in wpa.c

[Gábor Stefanik]

On Sat, Aug 1, 2009 at 9:11 AM, Johannes Berg<johannes@sipsolutions.net> wrote:
> On Fri, 2009-07-31 at 14:42 -0700, Ben Greear wrote:
>> It seems to me that in this method (and others), wpa_test is not
>> actually assigned a useful value, but it's still tested in code
>> branches.
>
>>
>> Any idea on how this is supposed to work?
>
> It isn't really. It's some dead code that you can enable manually for
> testing or so. It used to be possible to use a private ioctl or so to
> set it, iirc, but that's long gone. I'd have no objections to just
> removing it.
>
> johannes
>

Also, it doesn't look like this is getting compiled in any build -
AFAIK "txrx" classes are long gone (since 2.6.26 or so)...

-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)