From: Patrick Simmons <linuxrocks123@netscape.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: David Miller <davem@davemloft.net>,
mb@bu3sch.de, linux-wireless@vger.kernel.org, dsd@gentoo.org,
kune@deine-taler.de
Subject: Re: [PATCH] Fix SPARC64 unaligned access in zd_mac_rx
Date: Sun, 02 Aug 2009 02:45:40 -0600 [thread overview]
Message-ID: <4A755234.2030005@netscape.net> (raw)
In-Reply-To: <1249202040.2007.48.camel@johannes.local>
Johannes Berg wrote:
> On Sun, 2009-08-02 at 02:24 -0600, Patrick Simmons wrote:
>
>
>> It does look wrong, now that I look at it further, but I'm pretty sure
>> that what was happening was that only the lower 8 bits of the
>> dereferenced value were being accessed.
>>
>
> Yes, you're right, because buffer is a "u8 *", I initially thought that
> it didn't take a pointer, but that wouldn't work, of course.
>
>
>> What's odd is that it works on
>> my machine, though. Whatever. Your version is clearer, in any case.
>>
>> What follows is hopefully the last version of this patch.
>>
>
> Looks good, but I think you should resubmit with
> * a changed subject (e.g. "zd1211rw: fix unaligned access in zd_mac_rx")
> * a standalone patch description so John doesn't have to pick it out of
> your first patch etc.
>
>
> Thanks!
> johannes
>
>
Sure thing; here it comes. Thanks for the review.
--Patrick
next prev parent reply other threads:[~2009-08-02 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 7:59 [PATCH] Fix SPARC64 unaligned access in zd_mac_rx Patrick Simmons
2009-07-31 8:39 ` Johannes Berg
2009-08-01 5:23 ` David Miller
2009-08-01 10:40 ` Michael Buesch
2009-08-01 16:12 ` David Miller
2009-08-02 1:41 ` Patrick Simmons
2009-08-02 7:50 ` Johannes Berg
2009-08-02 8:24 ` Patrick Simmons
2009-08-02 8:34 ` Johannes Berg
2009-08-02 8:45 ` Patrick Simmons [this message]
2009-08-02 8:46 ` [PATCH] zd1211rw: fix " Patrick Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A755234.2030005@netscape.net \
--to=linuxrocks123@netscape.net \
--cc=davem@davemloft.net \
--cc=dsd@gentoo.org \
--cc=johannes@sipsolutions.net \
--cc=kune@deine-taler.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).