From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: netdev@vger.kernel.org, linux-zigbee-devel@lists.sourceforge.net,
linux-wireless@vger.kernel.org, Sergey Lapin <slapin@ossfans.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 2/2] ieee802154: add virtual loopback driver
Date: Mon, 10 Aug 2009 19:28:55 +0200 [thread overview]
Message-ID: <4A8058D7.7070106@hartkopp.net> (raw)
In-Reply-To: <1249913800-10176-3-git-send-email-dbaryshkov@gmail.com>
Dmitry Eremin-Solenikov wrote:
> fakelb is a virtual loopback driver implementing one or several
> interconnected radios.
> +
> +static int radios = 3;
> +module_param(radios, int, 0444);
> +MODULE_PARM_DESC(radios, "Number of simulated radios");
> +
> +
> + for (i = 0; i < radios; i++) {
> + err = ieee802154fake_add_priv(&pdev->dev, priv);
> + if (err < 0)
> + goto err_slave;
> + }
> +
Hi Dimtry,
creating software networking devices like this is IMO not state-of-the-art for
kernel inclusion.
Please use the NETLINK interface for creating the virtual loopback drivers,
like e.g. the virtual CAN driver (drivers/net/can/vcan.c) does.
Regards,
Oliver
next prev parent reply other threads:[~2009-08-10 17:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 14:16 [RFC 0/2] Software implementation of IEEE 802.15.4 Dmitry Eremin-Solenikov
2009-08-10 14:16 ` [PATCH 1/2] mac802154: add a software MAC 802.15.4 implementation Dmitry Eremin-Solenikov
2009-08-10 14:16 ` [PATCH 2/2] ieee802154: add virtual loopback driver Dmitry Eremin-Solenikov
2009-08-10 14:29 ` Johannes Berg
2009-08-10 17:28 ` Oliver Hartkopp [this message]
2009-08-10 14:27 ` [PATCH 1/2] mac802154: add a software MAC 802.15.4 implementation Johannes Berg
2009-08-11 20:23 ` Dmitry Eremin-Solenikov
2009-08-11 20:39 ` Johannes Berg
2009-08-12 13:06 ` Dmitry Eremin-Solenikov
2009-08-12 13:13 ` Johannes Berg
2009-08-12 20:46 ` Dmitry Eremin-Solenikov
2009-08-10 17:28 ` Paul E. McKenney
2009-08-11 20:29 ` Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8058D7.7070106@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=dbaryshkov@gmail.com \
--cc=kaber@trash.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=slapin@ossfans.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).