Re: [PATCH] b43: Fix a typo in the sync_stx routine

[Larry Finger <Larry.Finger@lwfinger.net>]

Gábor Stefanik wrote:
> I completely missed the "one's complement" instruction from the specs.
> 
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> ---
> drivers/net/wireless/b43/phy_lp.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/b43/phy_lp.c
> b/drivers/net/wireless/b43/phy_lp.c
> index 46fe476..34ad738 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -578,7 +578,7 @@ static void lpphy_sync_stx(struct b43_wldev *dev)
>         tmp >>= e->rf_shift;
>         tmp <<= e->phy_shift;
>         b43_phy_maskset(dev, B43_PHY_OFDM(0xF2 + e->phy_offset),
> -                e->mask << e->phy_shift, tmp);
> +                ~(e->mask << e->phy_shift), tmp);
>     }
> }
> 

I should have caught that one.

When debugging gets started, it might be useful to add a statement

      WARN_ON(mask & set);

at the start of b43_radio_maskset() and b43_phy_maskset(). That way
these kind of mistakes will be caught early.

Larry