From: Larry Finger <Larry.Finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: "Gábor Stefanik" <netrolller.3d@gmail.com>,
"John Linville" <linville@tuxdriver.com>,
"Broadcom Wireless" <bcm43xx-dev@lists.berlios.de>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] b43: Update dummy transmission to match V4 specs
Date: Thu, 13 Aug 2009 14:47:05 -0500 [thread overview]
Message-ID: <4A846DB9.8080802@lwfinger.net> (raw)
In-Reply-To: <200908131923.29847.mb@bu3sch.de>
Michael Buesch wrote:
> On Thursday 13 August 2009 16:51:51 Gábor Stefanik wrote:
>> The V4 dummy transmission has two extra bools in its prototype,
>> so update all callers with the 2 bools.
>>
>> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
>> ---
>> v2: Convert all callers to v4, and drop the v3->v4 wrapper.
>
>> - /* Commit writes */
>> - b43_read32(dev, B43_MMIO_MACCTL);
>
>> - value = ((phy->type == B43_PHYTYPE_A) ? 1 : 0);
>> + if (dev->dev->id.revision < 11)
>> + b43_write16(dev, 0x07C0, 0x0000);
>> + else
>> + b43_write16(dev, 0x07C0, 0x0100);
>> + value = (ofdm ? 0x41 : 0x40);
>> b43_write16(dev, 0x050C, value);
>
> This patch changes G-PHY codepaths. Did you test it on (at least one) G-PHY device?
>
My device with the 0x4312 ID still works with this patch applied.
Larry
prev parent reply other threads:[~2009-08-13 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 14:51 [PATCH v2] b43: Update dummy transmission to match V4 specs Gábor Stefanik
2009-08-13 17:23 ` Michael Buesch
2009-08-13 18:02 ` Gábor Stefanik
2009-08-13 19:47 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A846DB9.8080802@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).