From: Mario Limonciello <mario_limonciello@dell.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Alan Jenkins <sourcejedi.lkml@googlemail.com>,
Marcel Holtmann <marcel@holtmann.org>,
cezary.jackiewicz@gmail.com, linux-acpi@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/3] Add rfkill support to compal-laptop
Date: Wed, 19 Aug 2009 13:39:23 -0500 [thread overview]
Message-ID: <4A8C46DB.8040904@dell.com> (raw)
In-Reply-To: <1250702012.8073.1.camel@johannes.local>
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
Johannes:
Johannes Berg wrote:
> Hi Mario,
>
> First, let me say I agree with Alan, the option 1 is more desirable if
> possible to do with the hardware. But this looks ok from an rfkill POV
> now, except there's a small bug:
>
>
It looks like option 1 works properly on my hardware, so I've switched
the other code around.
>
> That doesn't error out, so
>
>
>
> this will crash without NULL checks.
>
> (and you have to explicitly assign NULL in setup_rfkill() too, when
> bluetooth fails and wifi is freed)
>
>
OK, i've cleaned that up to just error out on the module if rfkill
doesn't get initialized right.
> johannes
>
I've resent separately, and think I have git send-email working, so
hopefully won't have to attach in the future.
--
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2009-08-19 18:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4A89E768.7010207@dell.com>
[not found] ` <1250558643.30166.109.camel@localhost.localdomain>
[not found] ` <9b2b86520908180044l72cb8642j6256e246662f7971@mail.gmail.com>
[not found] ` <9b2b86520908180752k66feda09rf9034a96ac6ef470@mail.gmail.com>
[not found] ` <4A8AE459.8060102@dell.com>
2009-08-18 21:08 ` [PATCH 2/3] Add rfkill support to compal-laptop Alan Jenkins
2009-08-18 21:31 ` Johannes Berg
2009-08-18 22:00 ` Mario Limonciello
2009-08-19 8:51 ` Alan Jenkins
2009-08-19 9:01 ` Johannes Berg
2009-08-19 11:43 ` Cezary Jackiewicz
2009-08-19 16:46 ` Mario Limonciello
2009-08-19 16:57 ` Alan Jenkins
2009-08-19 17:13 ` Johannes Berg
2009-08-19 18:39 ` Mario Limonciello [this message]
2009-08-19 18:36 Mario Limonciello
2009-08-19 18:42 ` Johannes Berg
2009-08-19 18:47 ` Mario Limonciello
2009-08-20 8:52 ` Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8C46DB.8040904@dell.com \
--to=mario_limonciello@dell.com \
--cc=cezary.jackiewicz@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=sourcejedi.lkml@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).