From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Johannes Berg <johannes@sipsolutions.net>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Oikarinen Juuso (Nokia-D-MSW/Tampere)"
<juuso.oikarinen@nokia.com>,
"Valo Kalle (Nokia-D/Tampere)" <Kalle.Valo@nokia.com>
Subject: Re: [PATCH 13/13] wl1271: added Juuso Oikarinen as module author
Date: Fri, 28 Aug 2009 12:27:08 +0300 [thread overview]
Message-ID: <4A97A2EC.1080302@nokia.com> (raw)
In-Reply-To: <1251450604.3456.1.camel@johannes.local>
ext Johannes Berg wrote:
> On Fri, 2009-08-28 at 12:01 +0300, Luciano Coelho wrote:
>
>
>> Is that the right way to do it? At least in include/linux/module.h it
>> says this:
>>
>> /* Author, ideally of form NAME[, NAME]*[ and NAME] */
>> #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
>>
>
> Interesting, but I suspect that should just be changed.
>
> If you use multiple MODULE_AUTHOR, they will be shown as such:
>
> $ /sbin/modinfo ar9170usb | grep author
> author: Christian Lamparter <chunkeey@web.de>
> author: Johannes Berg <johannes@sipsolutions.net>
>
>
> If you use just one, it would be one long author: line with all of them.
> I think the multiple line case is much nicer.
>
Yes, I totally agree with you. I'll use multiple MODULE_AUTHOR()s. ;)
--
Cheers,
Luca.
next prev parent reply other threads:[~2009-08-28 9:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 20:59 [PATCH 00/13] wl1271: patch set with various improvements Luciano Coelho
2009-08-27 20:59 ` [PATCH 01/13] wl1271: remove unecessary qual parameter from rx status Luciano Coelho
2009-08-27 20:59 ` [PATCH 02/13] wl1271: Correction to TX block allocation calculation Luciano Coelho
2009-08-27 20:59 ` [PATCH 03/13] wl1271: Security sequence number handling for TX (for WPA) Luciano Coelho
2009-08-27 20:59 ` [PATCH 04/13] wl1271: Correct TKIP header space handling in TX path Luciano Coelho
2009-08-27 20:59 ` [PATCH 05/13] wl1271: Implement delayed entry into ELP Luciano Coelho
2009-08-27 21:00 ` [PATCH 06/13] wl1271: mask aid bits 14 and 15 in ps-poll template Luciano Coelho
2009-08-27 21:00 ` [PATCH 07/13] wl1271: Implementation for SPI busy word checking Luciano Coelho
2009-08-27 21:00 ` [PATCH 08/13] wl1271: Configure rate policies based on AP rates Luciano Coelho
2009-08-27 21:00 ` [PATCH 09/13] wl1271: Update join usage Luciano Coelho
2009-08-27 21:00 ` [PATCH 10/13] wl1271: Corrections to TX path Luciano Coelho
2009-08-27 21:00 ` [PATCH 11/13] wl1271: use workqueue provided by mac80211 instead of the default Luciano Coelho
2009-08-27 21:02 ` Luis R. Rodriguez
2009-08-27 21:17 ` Luciano Coelho
2009-08-27 21:00 ` [PATCH 12/13] wl1271: Clear probe-request template after scan Luciano Coelho
2009-08-27 21:00 ` [PATCH 13/13] wl1271: added Juuso Oikarinen as module author Luciano Coelho
2009-08-27 21:32 ` Johannes Berg
2009-08-27 21:35 ` Luis R. Rodriguez
2009-08-27 21:47 ` Luis R. Rodriguez
2009-08-28 9:01 ` Luciano Coelho
2009-08-28 9:10 ` Johannes Berg
2009-08-28 9:27 ` Luciano Coelho [this message]
2009-08-27 21:20 ` [PATCH 00/13] wl1271: patch set with various improvements Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A97A2EC.1080302@nokia.com \
--to=luciano.coelho@nokia.com \
--cc=Kalle.Valo@nokia.com \
--cc=johannes@sipsolutions.net \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).