From: Joerg Albert <jal2@gmx.de>
To: Johannes Berg <johannes@sipsolutions.net>,
Christian Lamparter <chunkeey@web.de>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>
Subject: Re: [RFT] ar9170: use eeprom's frequency calibration values
Date: Sat, 29 Aug 2009 13:33:23 +0200 [thread overview]
Message-ID: <4A991203.8070407@gmx.de> (raw)
In-Reply-To: <1250927567.23605.9.camel@johannes.local>
On 08/22/2009 09:52 AM, Johannes Berg wrote:
> On Fri, 2009-08-21 at 22:52 +0200, Christian Lamparter wrote:
>
>> Johannes, in phy.c (now at line) line 429
>>
>> int ar9170_init_phy(struct ar9170 *ar, enum ieee80211_band band)
>> {
>> [...]
>> /* XXX: use EEPROM data here! */
>>
>> err = ar9170_init_power_cal(ar);
>> if (err)
>> [...]
>> }
>>
>> do you still know what EEPROM data is missing here?
>
> Sorry, no, I don't remember, and can't seem to find it either in otus
> right now.
Maybe this refers to the values in eepromBoardData initialized from the eeprom in otus/hal/hpmain.c, lines 522 ff.
and written into the registers in line 828?
I guess they should come from the modal_header[] in struct ar9170_eeprom, but I cannot map the
offset in hpmain.c for hpPriv->eepromImage[] into the modal_header's members.
Regards,
Joerg
prev parent reply other threads:[~2009-08-29 11:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 20:52 [RFT] ar9170: use eeprom's frequency calibration values Christian Lamparter
2009-08-21 23:36 ` Joerg Albert
2009-08-21 23:51 ` Christian Lamparter
2009-08-22 21:03 ` Joerg Albert
2009-08-22 21:43 ` Christian Lamparter
2009-08-22 7:52 ` Johannes Berg
2009-08-29 11:33 ` Joerg Albert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A991203.8070407@gmx.de \
--to=jal2@gmx.de \
--cc=chunkeey@web.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).