linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH 3/7] wireless: update cfg80211 kconfig entry
Date: Tue, 01 Sep 2009 10:37:12 -0500	[thread overview]
Message-ID: <4A9D3FA8.9020800@lwfinger.net> (raw)
In-Reply-To: <1251818566-9264-4-git-send-email-lrodriguez@atheros.com>

Luis R. Rodriguez wrote:
> cfg80211 is now *the* wireless configuration API. Lets also
> give a little explanation as to what it is and refer people to
> the wireless wiki for more information.
> 
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
>  net/wireless/Kconfig |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
> 
> diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
> index aea7e68..9fd570b 100644
> --- a/net/wireless/Kconfig
> +++ b/net/wireless/Kconfig
> @@ -1,6 +1,15 @@
>  config CFG80211
> -	tristate "Improved wireless configuration API"
> +	tristate "cfg80211 - wireless configuration API"
>  	depends on RFKILL || !RFKILL
> +	---help---
> +	  cfg80211 is the Linux wireless LAN (802.11) configuration API.
> +	  Enable this if you have a wireless device.
> +
> +	  For more information refer to documentation on the wireless wiki:
> +
> +	  http://wireless.kernel.org/en/developers/Documentation/cfg80211
> +
> +	  When built as a module cfg80211 will be built as cfg80211

First of all, I think this modest change is much better than the
previous set of patches, and that the additional info you provide for
mac80211 and friends will be useful for those who don't live with
802.11 wifi all day long.

That said, I find the above statement to be a little clumsy. Perhaps
it should be "When built as a module, it will be called cfg80211". The
same comment also applies to patch 6 for mac80211.

Larry


  reply	other threads:[~2009-09-01 15:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-01 15:22 [PATCH 0/7] wireless: few kconfig updates Luis R. Rodriguez
2009-09-01 15:22 ` [PATCH 1/7] wireless: update top level wireless driver entry Luis R. Rodriguez
2009-09-01 15:22 ` [PATCH 2/7] wireless: update wireless kconfig description Luis R. Rodriguez
2009-09-01 15:31   ` Johannes Berg
2009-09-01 15:46     ` Luis R. Rodriguez
2009-09-01 15:22 ` [PATCH 3/7] wireless: update cfg80211 kconfig entry Luis R. Rodriguez
2009-09-01 15:37   ` Larry Finger [this message]
2009-09-01 15:47     ` Luis R. Rodriguez
2009-09-01 15:22 ` [PATCH 4/7] wireless: update reg debug " Luis R. Rodriguez
2009-09-01 15:22 ` [PATCH 5/7] wireless: update WIRELESS_EXT " Luis R. Rodriguez
2009-09-01 15:53   ` Larry Finger
2009-09-01 15:54     ` Johannes Berg
2009-09-01 16:58       ` John W. Linville
2009-09-01 15:22 ` [PATCH 6/7] wireless: update mac80211 " Luis R. Rodriguez
2009-09-01 15:22 ` [PATCH 7/7] wireless: remove mac80211 rate selection extra menu Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9D3FA8.9020800@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).