From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Norbert Preining <preining@logic.at>,
linux-wireless@vger.kernel.org,
Mattia Dongili <malattia@linux.it>,
"Almer S. Tigelaar" <almer@gnome.org>,
Matthias Welwarsky <matze@welwarsky.de>
Subject: Re: rfkill hard state after booting
Date: Thu, 24 Sep 2009 16:12:30 +0100 [thread overview]
Message-ID: <4ABB8C5E.6070402@tuffmail.co.uk> (raw)
In-Reply-To: <1253804713.3868.168.camel@johannes.local>
Johannes Berg wrote:
> On Thu, 2009-09-24 at 16:01 +0100, Alan Jenkins wrote:
>
>
>> I think it's pretty clear it's in the sony code. It doesn't call
>> set_hw_state() during init. I.e. (completely untested):
>>
>
> Agree, looking at the code this seems reasonable.
>
> Although maybe it should just call sony_nc_rfkill_update() after
> registering all of them?
>
> johannes
>
That means the initial "add" uevents etc. will contain wrong values (and
then be updated immediately after). Do we care about that? It's
unlikely to matter in practice for platform devices which only get
loaded at boot-time, but perhaps it would set a bad example.
Regards
Alan
next prev parent reply other threads:[~2009-09-24 15:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 13:02 rfkill hard state after booting Norbert Preining
2009-09-24 14:07 ` Johannes Berg
2009-09-24 15:01 ` Alan Jenkins
2009-09-24 15:05 ` Johannes Berg
2009-09-24 15:12 ` Alan Jenkins [this message]
2009-09-24 17:29 ` Johannes Berg
2009-09-24 19:15 ` [PATCH] sony-laptop: check for rfkill hard block at load time Alan Jenkins
2009-09-24 19:24 ` Gábor Stefanik
2009-09-24 20:11 ` Alan Jenkins
2009-09-24 23:04 ` Mattia Dongili
2009-09-24 19:27 ` Johannes Berg
2009-09-24 22:38 ` Mattia Dongili
2009-09-25 9:13 ` Alan Jenkins
2009-09-24 16:19 ` rfkill hard state after booting Norbert Preining
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABB8C5E.6070402@tuffmail.co.uk \
--to=alan-jenkins@tuffmail.co.uk \
--cc=almer@gnome.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=malattia@linux.it \
--cc=matze@welwarsky.de \
--cc=preining@logic.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).