From: Tim Gardner <tim.gardner@canonical.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [iw PATCH] default install to $(PREFIX)/sbin
Date: Wed, 30 Sep 2009 11:21:07 -0600 [thread overview]
Message-ID: <4AC39383.9010109@canonical.com> (raw)
In-Reply-To: <1254316786-4670-1-git-send-email-linville@tuxdriver.com>
John W. Linville wrote:
> The iw utility isn't generally useful to normal users, so move it to
> $(PREFIX)/sbin with other system management executables.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> As "suggested" by Johannes... :-)
>
> Makefile | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index cb5fcc1..68bef4d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3,7 +3,7 @@
> MAKEFLAGS += --no-print-directory
>
> PREFIX ?= /usr
> -BINDIR ?= $(PREFIX)/bin
> +SBINDIR ?= $(PREFIX)/sbin
> MANDIR ?= $(PREFIX)/share/man
> PKG_CONFIG ?= pkg-config
>
> @@ -85,8 +85,8 @@ check:
>
> install: iw iw.8.gz
> @$(NQ) ' INST iw'
> - $(Q)$(MKDIR) $(DESTDIR)$(BINDIR)
> - $(Q)$(INSTALL) -m 755 -t $(DESTDIR)$(BINDIR) iw
> + $(Q)$(MKDIR) $(DESTDIR)$(SBINDIR)
> + $(Q)$(INSTALL) -m 755 -t $(DESTDIR)$(SBINDIR) iw
> @$(NQ) ' INST iw.8'
> $(Q)$(MKDIR) $(DESTDIR)$(MANDIR)/man8/
> $(Q)$(INSTALL) -m 644 -t $(DESTDIR)$(MANDIR)/man8/ iw.8.gz
FWIW Ubuntu wireless-tools drops rfkill in /sbin, where I think tools
that require root for changes should live.
rtg
--
Tim Gardner tim.gardner@canonical.com
prev parent reply other threads:[~2009-09-30 17:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 13:19 [iw PATCH] default install to $(PREFIX)/sbin John W. Linville
2009-09-30 17:21 ` Tim Gardner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC39383.9010109@canonical.com \
--to=tim.gardner@canonical.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).