* [PATCH] mac80211: use kfree_skb() to free struct sk_buff pointers
@ 2009-10-06 13:52 Roel Kluin
2009-10-06 13:46 ` Johannes Berg
2009-10-06 15:37 ` Luis R. Rodriguez
0 siblings, 2 replies; 3+ messages in thread
From: Roel Kluin @ 2009-10-06 13:52 UTC (permalink / raw)
To: Johannes Berg, linux-wireless, Andrew Morton
kfree_skb() should be used to free struct sk_buff pointers.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/net/mac80211/util.c b/net/mac80211/util.c
index dd65643..aeb65b3 100644
--- a/net/mac80211/util.c
+++ b/net/mac80211/util.c
@@ -339,7 +339,7 @@ void ieee80211_add_pending_skb(struct ieee80211_local *local,
struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
if (WARN_ON(!info->control.vif)) {
- kfree(skb);
+ kfree_skb(skb);
return;
}
@@ -367,7 +367,7 @@ int ieee80211_add_pending_skbs(struct ieee80211_local *local,
struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
if (WARN_ON(!info->control.vif)) {
- kfree(skb);
+ kfree_skb(skb);
continue;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mac80211: use kfree_skb() to free struct sk_buff pointers
2009-10-06 13:52 [PATCH] mac80211: use kfree_skb() to free struct sk_buff pointers Roel Kluin
@ 2009-10-06 13:46 ` Johannes Berg
2009-10-06 15:37 ` Luis R. Rodriguez
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2009-10-06 13:46 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-wireless, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 933 bytes --]
On Tue, 2009-10-06 at 15:52 +0200, Roel Kluin wrote:
> kfree_skb() should be used to free struct sk_buff pointers.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Indeed, thanks.
Acked-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> index dd65643..aeb65b3 100644
> --- a/net/mac80211/util.c
> +++ b/net/mac80211/util.c
> @@ -339,7 +339,7 @@ void ieee80211_add_pending_skb(struct ieee80211_local *local,
> struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
>
> if (WARN_ON(!info->control.vif)) {
> - kfree(skb);
> + kfree_skb(skb);
> return;
> }
>
> @@ -367,7 +367,7 @@ int ieee80211_add_pending_skbs(struct ieee80211_local *local,
> struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
>
> if (WARN_ON(!info->control.vif)) {
> - kfree(skb);
> + kfree_skb(skb);
> continue;
> }
>
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mac80211: use kfree_skb() to free struct sk_buff pointers
2009-10-06 13:52 [PATCH] mac80211: use kfree_skb() to free struct sk_buff pointers Roel Kluin
2009-10-06 13:46 ` Johannes Berg
@ 2009-10-06 15:37 ` Luis R. Rodriguez
1 sibling, 0 replies; 3+ messages in thread
From: Luis R. Rodriguez @ 2009-10-06 15:37 UTC (permalink / raw)
To: Roel Kluin; +Cc: Johannes Berg, linux-wireless, Andrew Morton
On Tue, Oct 6, 2009 at 9:52 AM, Roel Kluin <roel.kluin@gmail.com> wrote:
> kfree_skb() should be used to free struct sk_buff pointers.
cc'ing stable would be good for this one it seems.
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-06 15:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-06 13:52 [PATCH] mac80211: use kfree_skb() to free struct sk_buff pointers Roel Kluin
2009-10-06 13:46 ` Johannes Berg
2009-10-06 15:37 ` Luis R. Rodriguez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).