From: Larry Finger <Larry.Finger@lwfinger.net>
To: Albert Herranz <albert_herranz@yahoo.es>
Cc: bcm43xx-dev@lists.berlios.de, mb@bu3sch.de,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] b43: do not stack-allocate pio rx/tx header and tail buffers
Date: Wed, 07 Oct 2009 13:01:09 -0500 [thread overview]
Message-ID: <4ACCD765.7080604@lwfinger.net> (raw)
In-Reply-To: <4ACCC893.1010402@yahoo.es>
Albert Herranz wrote:
> Larry Finger wrote:
>> Albert Herranz wrote:
>
> b43_new_kidx_api() (defined in xmit.h) needs struct b43_wldev defined because it dereferences it.
> With this patch, struct b43_wl (defined in b43.h) needs struct b43_rxhdr_fw4 and struct b43_txhdr (defined in xmit.h).
>
> So we have b43_wldev -> b43_rxhdr_fw4, b43_txhdr -> b43_wl (at least).
>
> Moving the definition of struct b43_wl after the definition of struct b43_wldev and placing the inclusion of xmit.h between them gets rid of the generated dependencies.
>
> The patch hints too to other possible solution.
>
>> /*
>> * Include goes here to avoid a dependency problem.
>> * A better fix would be to integrate xmit.h into b43.h.
>> */
>> #include "xmit.h"
>
> Do you have any other solutions in mind?
No. I missed the hint. At first I thought there was a white-space
problem that caused b43_wl to be replaced. When that was not the case,
I posed my question.
All seems OK.
Larry
next prev parent reply other threads:[~2009-10-07 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 16:20 [PATCH] b43: do not stack-allocate pio rx/tx header buffers Albert Herranz
2009-10-06 20:52 ` Michael Buesch
2009-10-06 21:13 ` John W. Linville
2009-10-06 22:07 ` [PATCH v2] b43: do not stack-allocate pio rx/tx header and tail buffers Albert Herranz
2009-10-07 16:43 ` Larry Finger
2009-10-07 16:57 ` Albert Herranz
2009-10-07 18:01 ` Larry Finger [this message]
2009-10-09 17:46 ` b43: do not stack-allocate pio rx/tx header and tail buffers (was: pull request: wireless-2.6 2009-10-08) Albert Herranz
2009-10-09 18:05 ` Michael Buesch
2009-10-09 18:52 ` b43: do not stack-allocate pio rx/tx header and tail buffers Albert Herranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACCD765.7080604@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=albert_herranz@yahoo.es \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).