From: Randy Dunlap <randy.dunlap@oracle.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wireless: make WEXT_SPY and WEXT_PRIV select WEXT_CORE
Date: Wed, 07 Oct 2009 15:54:53 -0700 [thread overview]
Message-ID: <4ACD1C3D.3030506@oracle.com> (raw)
In-Reply-To: <1254954842.3713.7.camel@johannes.local>
Johannes Berg wrote:
> On Wed, 2009-10-07 at 14:55 -0700, Randy Dunlap wrote:
>> John W. Linville wrote:
>>> Should prevent this build error reported by Randy...
>>>
>>> net/wireless/wext-priv.c:206: error: implicit declaration of function 'call_commit_handler'
>>> make[3]: *** [net/wireless/wext-priv.o] Error 1
>>>
>>> Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
>>> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>> Sorry, it did not work for me.
>
>> linux-next-20091007/net/wireless/wext-priv.c:206: error: implicit declaration of function 'call_commit_handler'
>> make[3]: *** [net/wireless/wext-priv.o] Error 1
>>
>> Drivers like hostap and orinoco (hermes) select WEXT_PRIV regardless
>> of the setting of WEXT_CORE. oh, and staging/ drivers do that also.
>
> But they also select WIRELESS_EXT, which should cause WEXT_CORE to be
> turned on. Is it possible that is failing?
# CONFIG_WIRELESS is not set
CONFIG_WIRELESS_EXT=y
CONFIG_WEXT_SPY=y
CONFIG_WEXT_PRIV=y
WEXT_CORE is not enabled. I haven't found the culprit, but I suspect "select".
but what in WIRELESS_EXT would also cause WEXT_CORE to be enabled?
~Randy
next prev parent reply other threads:[~2009-10-07 22:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091007173517.abfcfa2a.sfr@canb.auug.org.au>
2009-10-07 17:52 ` linux-next: Tree for October 7 (libertas build failure) Randy Dunlap
2009-10-07 18:12 ` Dan Williams
2009-10-07 22:34 ` Johannes Berg
2009-10-07 17:57 ` linux-next: Tree for October 7 (wireless/wext) Randy Dunlap
2009-10-07 21:07 ` [PATCH] wireless: make WEXT_SPY and WEXT_PRIV select WEXT_CORE John W. Linville
2009-10-07 21:55 ` Randy Dunlap
2009-10-07 22:34 ` Johannes Berg
2009-10-07 22:54 ` Randy Dunlap [this message]
2009-10-07 23:14 ` Johannes Berg
2009-10-08 0:12 ` Randy Dunlap
2009-10-08 9:48 ` Johannes Berg
2009-10-08 15:06 ` Randy Dunlap
2009-10-08 18:29 ` Johannes Berg
2009-10-09 16:06 ` Randy Dunlap
2009-10-09 16:14 ` Johannes Berg
2009-10-09 16:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACD1C3D.3030506@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).