* [PATCH] mac80211: fix logic error ibss merge bssid check
@ 2009-10-11 3:21 Felix Fietkau
2009-10-11 9:43 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Felix Fietkau @ 2009-10-11 3:21 UTC (permalink / raw)
To: linux-wireless; +Cc: Johannes Berg, John W. Linville
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -544,7 +544,7 @@ static void ieee80211_sta_find_ibss(stru
"%pM\n", bss->cbss.bssid, ifibss->bssid);
#endif /* CONFIG_MAC80211_IBSS_DEBUG */
- if (bss && memcmp(ifibss->bssid, bss->cbss.bssid, ETH_ALEN)) {
+ if (bss && !memcmp(ifibss->bssid, bss->cbss.bssid, ETH_ALEN)) {
printk(KERN_DEBUG "%s: Selected IBSS BSSID %pM"
" based on configured SSID\n",
sdata->dev->name, bss->cbss.bssid);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mac80211: fix logic error ibss merge bssid check
2009-10-11 3:21 [PATCH] mac80211: fix logic error ibss merge bssid check Felix Fietkau
@ 2009-10-11 9:43 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2009-10-11 9:43 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, John W. Linville
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On Sun, 2009-10-11 at 05:21 +0200, Felix Fietkau wrote:
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>
> --- a/net/mac80211/ibss.c
> +++ b/net/mac80211/ibss.c
> @@ -544,7 +544,7 @@ static void ieee80211_sta_find_ibss(stru
> "%pM\n", bss->cbss.bssid, ifibss->bssid);
> #endif /* CONFIG_MAC80211_IBSS_DEBUG */
>
> - if (bss && memcmp(ifibss->bssid, bss->cbss.bssid, ETH_ALEN)) {
> + if (bss && !memcmp(ifibss->bssid, bss->cbss.bssid, ETH_ALEN)) {
Acked-by: Johannes Berg <johannes@sipsolutions.net>
I'll also send the race fix now, would appreciate you giving it a try.
Thanks,
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-11 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-11 3:21 [PATCH] mac80211: fix logic error ibss merge bssid check Felix Fietkau
2009-10-11 9:43 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).