Re: [RFC] wl1271: use __dev_alloc_skb() on RX

[Luciano Coelho <luciano.coelho@nokia.com>]

Hi Luiz,

ext Luis R. Rodriguez wrote:
> RX is handled in a workqueue therefore allocating for GFP_ATOMIC
> is overkill and not required.


Yes, this looks like the correct thing to do.  Thank you for pointing out! Can 
you send the patch again to Linville for integration?


> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> 
> --- 
> 
> This goes untested and not even compile tested but just thought this was odd.
> 
> diff --git a/drivers/net/wireless/wl12xx/wl1271_rx.c b/drivers/net/wireless/wl12xx/wl1271_rx.c
> index 37d81ab..ca645f3 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_rx.c
> +++ b/drivers/net/wireless/wl12xx/wl1271_rx.c
> @@ -159,7 +159,7 @@ static void wl1271_rx_handle_data(struct wl1271 *wl, u32 length)
>  	u8 *buf;
>  	u8 beacon = 0;
>  
> -	skb = dev_alloc_skb(length);
> +	skb = __dev_alloc_skb(length, GFP_KERNEL);
>  	if (!skb) {
>  		wl1271_error("Couldn't allocate RX frame");
>  		return;

Acked-by: Luciano Coelho <luciano.coelho@nokia.com>

-- 
Cheers,
Luca.