* [RFC] wl1271: use __dev_alloc_skb() on RX
@ 2009-10-30 18:35 Luis R. Rodriguez
2009-11-02 8:03 ` Luciano Coelho
0 siblings, 1 reply; 3+ messages in thread
From: Luis R. Rodriguez @ 2009-10-30 18:35 UTC (permalink / raw)
To: luciano.coelho; +Cc: linux-wireless, Luis R. Rodriguez
RX is handled in a workqueue therefore allocating for GFP_ATOMIC
is overkill and not required.
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
This goes untested and not even compile tested but just thought this was odd.
diff --git a/drivers/net/wireless/wl12xx/wl1271_rx.c b/drivers/net/wireless/wl12xx/wl1271_rx.c
index 37d81ab..ca645f3 100644
--- a/drivers/net/wireless/wl12xx/wl1271_rx.c
+++ b/drivers/net/wireless/wl12xx/wl1271_rx.c
@@ -159,7 +159,7 @@ static void wl1271_rx_handle_data(struct wl1271 *wl, u32 length)
u8 *buf;
u8 beacon = 0;
- skb = dev_alloc_skb(length);
+ skb = __dev_alloc_skb(length, GFP_KERNEL);
if (!skb) {
wl1271_error("Couldn't allocate RX frame");
return;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RFC] wl1271: use __dev_alloc_skb() on RX
2009-10-30 18:35 [RFC] wl1271: use __dev_alloc_skb() on RX Luis R. Rodriguez
@ 2009-11-02 8:03 ` Luciano Coelho
2009-11-02 8:30 ` Luciano Coelho
0 siblings, 1 reply; 3+ messages in thread
From: Luciano Coelho @ 2009-11-02 8:03 UTC (permalink / raw)
To: ext Luis R. Rodriguez; +Cc: linux-wireless@vger.kernel.org
Hi Luiz,
ext Luis R. Rodriguez wrote:
> RX is handled in a workqueue therefore allocating for GFP_ATOMIC
> is overkill and not required.
Yes, this looks like the correct thing to do. Thank you for pointing out! Can
you send the patch again to Linville for integration?
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
>
> ---
>
> This goes untested and not even compile tested but just thought this was odd.
>
> diff --git a/drivers/net/wireless/wl12xx/wl1271_rx.c b/drivers/net/wireless/wl12xx/wl1271_rx.c
> index 37d81ab..ca645f3 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_rx.c
> +++ b/drivers/net/wireless/wl12xx/wl1271_rx.c
> @@ -159,7 +159,7 @@ static void wl1271_rx_handle_data(struct wl1271 *wl, u32 length)
> u8 *buf;
> u8 beacon = 0;
>
> - skb = dev_alloc_skb(length);
> + skb = __dev_alloc_skb(length, GFP_KERNEL);
> if (!skb) {
> wl1271_error("Couldn't allocate RX frame");
> return;
Acked-by: Luciano Coelho <luciano.coelho@nokia.com>
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-02 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-30 18:35 [RFC] wl1271: use __dev_alloc_skb() on RX Luis R. Rodriguez
2009-11-02 8:03 ` Luciano Coelho
2009-11-02 8:30 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).