linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Schaefer <schaefer.frank@gmx.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ar9170usb: add mode-switching for AVM Fritz!WLAN USB N devices in cdrom mode
Date: Tue, 03 Nov 2009 21:42:43 +0100	[thread overview]
Message-ID: <4AF095C3.5020409@gmx.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0911031001470.10778-100000@netrider.rowland.org>

Alan Stern schrieb:
> On Mon, 2 Nov 2009, Dan Williams wrote
>> In userspace, usb_modeswitch is the place to put all this logic.  Then
>> you tie it together with udev rules using some bubble-gum and duct-tape,
>> and maybe it works.  Of course, there's massive duplication of data
>> between usb_modeswitch and the kernel drivers, because the there's
>> simply no communication between the two.
>>     
> The only reason for this "massive" duplication is that nobody has
> bothered to remove from the kernel the parts that usb_modeswitch can
> handle.  Adding yet more switching code into the kernel, thereby
> _increasing_ the amount of duplication, seems like a bad idea.
>   
Or the other way around ;) .

Of course, we all don't want any duplicate code. We need a kernelspace
OR a userspace-solution.
But we should make pragmatic and device-(group-)specific decisions.
The hardware itself and the context in which it is used (=>
switch-policy) are too different.

...
> ... Jobs that can be handled 
> in userspace _should_ be handled there.
>
> Alan Stern
>   

Basically, I have no problem to agree here.
But what's the price we pay for this solution(s) in this case (and most
other devices with windows-driver-disc-mode) ?
You should not ignore the problems coming-up with the discussed
userspace-solutions.
This is not ONLY about technical aspects. We already discussed usability
and maintanance. Think about the whole product, not only the kernel-part.
Then, please, make a list of ALL pros and cons a make a pragmatic decision.

Frank


  parent reply	other threads:[~2009-11-03 21:00 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200910171606.02961.oliver@neukum.org>
     [not found] ` <Pine.LNX.4.44L0.0910171130550.25594-100000@netrider.rowland.org>
     [not found]   ` <20091017220313.GH24502@one-eyed-alien.net>
     [not found]     ` <4ADC3657.6080906@gmx.net>
2009-11-01 18:00       ` [PATCH] ar9170usb: add mode-switching for AVM Fritz!WLAN USB N devices in cdrom mode Frank Schaefer
2009-11-01 18:27         ` Johannes Berg
2009-11-01 20:02           ` Frank Schaefer
2009-11-01 18:29         ` Josua Dietze
2009-11-01 18:35           ` Matthew Dharm
2009-11-01 20:24             ` Frank Schaefer
2009-11-01 20:49               ` Christian Lamparter
2009-11-02 20:16                 ` Frank Schaefer
2009-11-02  0:47               ` Matthew Dharm
2009-11-02 20:07                 ` Frank Schaefer
2009-11-02 21:10                   ` Matthew Dharm
2009-11-02 21:15                     ` Matthew Dharm
2009-11-03 20:33                     ` Frank Schaefer
2009-11-01 20:11           ` Frank Schaefer
2009-11-02  0:51             ` Matthew Dharm
2009-11-02 20:10               ` Frank Schaefer
2009-11-02 20:18                 ` Dan Williams
2009-11-02 21:05                   ` Alan Cox
2009-11-02 21:37                     ` Dan Williams
2009-11-02 21:45                     ` Dan Williams
2009-11-02 22:23                       ` Christian Lamparter
2009-11-03 20:22                       ` Frank Schaefer
2009-11-02 21:11                   ` Matthew Dharm
2009-11-02 21:42                     ` Dan Williams
2009-11-02 22:39                       ` Alan Cox
2009-11-03  0:54                         ` Dan Williams
2009-11-03 10:55                       ` Oliver Neukum
2009-11-03 15:16                       ` Alan Stern
2009-11-03 16:29                         ` Oliver Neukum
2009-11-03 22:47                           ` Alan Stern
2009-11-03 23:55                             ` Oliver Neukum
2009-11-04  3:57                               ` Alan Stern
2009-11-04  9:11                                 ` Oliver Neukum
2009-11-03 20:42                         ` Frank Schaefer [this message]
2009-11-04 16:16                           ` Alan Stern
2009-11-04 16:25                             ` Johannes Berg
2009-11-04 17:07                               ` Alan Stern
2009-11-04 17:41                                 ` Josua Dietze
2009-11-04 16:41                             ` Oliver Neukum
2009-11-04 17:41                               ` Josua Dietze
2009-11-03 10:57                     ` Oliver Neukum
2009-11-03 12:58                       ` Christian Lamparter
2009-11-03 20:18                   ` Frank Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF095C3.5020409@gmx.net \
    --to=schaefer.frank@gmx.net \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).