From: Larry Finger <Larry.Finger@lwfinger.net>
To: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Christian Lamparter <chunkeey@googlemail.com>,
Hin-Tak Leung <htl10@users.sourceforge.net>,
sidhayn@gmail.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtl8187: Fix kernel oops when device is removed when LEDS enabled (Bugzilla #14539)
Date: Wed, 04 Nov 2009 20:34:14 -0600 [thread overview]
Message-ID: <4AF239A6.5050406@lwfinger.net> (raw)
In-Reply-To: <200911042214.54230.herton@mandriva.com.br>
On 11/04/2009 06:14 PM, Herton Ronaldo Krzesinski wrote:
>
> Hi, I checked here and the code above in led_classdev_unregister is the same in
> 2.6.31, so I think the patch from Larry should also be applied/sent to 2.6.31.x
> stable, as the bug could happen there too.
Herton,
Technically you are correct; however, I did extensive testing of
2.6.31 and _NEVER_ got the failure. The sequencing is a bug waiting to
happen, but something in the post 2.6.31 merge actually enabled the
bug to happen. I tried bisection to determine which change actully did
that, but was not successful.
My feeling is that stable can be left alone. Of course, if bug reports
of kernel panics on unload of rtl8187 start occurring, we will know
how to fix it.
Larry
next prev parent reply other threads:[~2009-11-05 2:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 6:00 [PATCH] rtl8187: Fix kernel oops when device is removed when LEDS enabled (Bugzilla #14539) Larry Finger
2009-11-04 15:11 ` John W. Linville
2009-11-04 15:30 ` Christian Lamparter
2009-11-04 16:49 ` John W. Linville
2009-11-05 0:14 ` Herton Ronaldo Krzesinski
2009-11-05 2:34 ` Larry Finger [this message]
2009-11-05 4:55 ` Richard Farina
2009-11-05 5:16 ` Larry Finger
2009-11-04 15:54 ` Larry Finger
2009-11-04 16:54 ` John W. Linville
2009-11-04 18:13 ` Larry Finger
2009-11-04 18:47 ` John W. Linville
2009-11-05 4:57 ` Richard Farina
2009-11-05 6:00 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF239A6.5050406@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chunkeey@googlemail.com \
--cc=herton@mandriva.com.br \
--cc=htl10@users.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sidhayn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).