Re: [PATCH] rtl8187: Fix kernel oops when device is removed when LEDS enabled (Bugzilla #14539)

[Richard Farina <sidhayn@gmail.com>]

John W. Linville wrote:
> On Wed, Nov 04, 2009 at 12:13:02PM -0600, Larry Finger wrote:
>   
>> On 11/04/2009 10:54 AM, John W. Linville wrote:
>>     
>>> On Wed, Nov 04, 2009 at 09:54:37AM -0600, Larry Finger wrote:
>>>
>>>       
>>>> I will try once more to get netconsole working to capture the backtrace.
>>>>         
>>> No need, I think I understand it now.  The new order still sorta
>>> looks/feels "wrong", but it seems fine.  Maybe an alternative would
>>> be to make the brightness_set routine aware of the shutdown and not
>>> queue the work?  Maybe even ieee80211_queue_delayed_work could be
>>> made a bit smarter here?
>>>       
>> Are either of these questions a request, or are they musings?
>>     
>
> They are musings -- but feel free to be inspired! :-)
>
>   
I can't speak for "proper coding style" or "preferred fixes" or whatever 
you awesome coders call things, but I can say that myself and a few 
others have extensively test _this_ fix and can no longer crash the 
kernel.  As the original reporter I am more than satisfied that this is 
fixed.  Just my 0.02$

Thanks,
Rick Farina