From: Larry Finger <Larry.Finger@lwfinger.net>
To: Bob Copeland <me@bobcopeland.com>
Cc: Carlo Parata <carlo_parata@hotmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Wifi led does not work on Acer Aspire One D250 (ath5k driver)
Date: Fri, 06 Nov 2009 09:23:57 -0600 [thread overview]
Message-ID: <4AF43F8D.6090303@lwfinger.net> (raw)
In-Reply-To: <b6c5339f0911060716n538268f6w1300e3400e0bd2c8@mail.gmail.com>
On 11/06/2009 09:16 AM, Bob Copeland wrote:
> On Fri, Nov 6, 2009 at 8:00 AM, Carlo Parata <carlo_parata@hotmail.com> wrote:
>> With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of
>> compatible devices in ath5k driver now includes the hardware present in this
>> computer, as well as the led pin and polarity.
>>
>> --- ../led.c 2009-11-06 06:16:39.000000000 +0100
>> +++ ./drivers/net/wireless/ath/ath5k/led.c 2009-11-06 12:37:44.000000000 +0100
>> @@ -73,6 +73,8 @@
>> { ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
>> /* IBM-specific AR5212 (all others) */
>> { PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
>> + /* Acer Aspire One D250 AR5007EG */
>> + { PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },
>
> No, this should be based on the subdevice instead
> (there are lots of ath:001c with different LED settings).
>
> Also, please add your email to the appropriate stanza.
It is more than just your E-mail address. Please see
Documents/SubmittingPatches.
next prev parent reply other threads:[~2009-11-06 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 13:00 [PATCH] Wifi led does not work on Acer Aspire One D250 (ath5k driver) Carlo Parata
2009-11-06 15:16 ` Bob Copeland
2009-11-06 15:23 ` Larry Finger [this message]
2009-11-06 15:54 ` Carlo Parata
2009-11-06 16:01 ` Holger Schurig
2009-11-06 16:04 ` Bob Copeland
2009-11-06 16:09 ` John W. Linville
2009-11-06 16:21 ` Bob Copeland
2009-11-06 16:46 ` Carlo Parata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF43F8D.6090303@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=carlo_parata@hotmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).