linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH 7/7] rt2x00: Update copyright statements.
Date: Sun, 08 Nov 2009 15:42:19 +0100	[thread overview]
Message-ID: <4AF6D8CB.5090302@gmail.com> (raw)
In-Reply-To: <200911081525.58809.IvDoorn@gmail.com>

On 11/08/09 15:25, Ivo van Doorn wrote:
> On Sunday 08 November 2009, Gertjan van Wingerde wrote:
>> As mentioned on the linux-wireless mailing list, the current copyright statements in the rt2x00 are
>> meaningless, as the rt2x00 project is not even a formal legal entity. Therefore it is better to replace
>> the existing copyright statements with copyright statements for the people that actually wrote the code.
>>
>> Note: Updated to the best of my knowledge with respect to who contributed considerable amounts of code.
> 
> ...
> 
>> diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
>> index b0f4a2f..5322852 100644
>> --- a/drivers/net/wireless/rt2x00/Kconfig
>> +++ b/drivers/net/wireless/rt2x00/Kconfig
>> @@ -65,7 +65,7 @@ config RT2800PCI_SOC
>>  
>>  config RT2800PCI
>>  	tristate "Ralink rt2800 (PCI/PCMCIA) support (BROKEN)"
>> -	depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL && BROKEN
>> +	depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL
>>  	select RT2800_LIB
>>  	select RT2X00_LIB_PCI if RT2800PCI_PCI
>>  	select RT2X00_LIB_SOC if RT2800PCI_SOC
> 
> You can omit this part of your patch. ;)

Ouch. I really messed this one up :-(

> 
>>  	This program is free software; you can redistribute it and/or modify
>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
>> index 5c7d74a..3207b83 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
>> @@ -3,7 +3,13 @@
>>  
>>  	Based on the original rt2800pci.c and rt2800usb.c:
>>  
>> -	  Copyright (C) 2004 - 2009 rt2x00 SourceForge Project
>> +	  Copyright (C) 2009 Ivo van Doorn <IvDoorn@gmail.com>
>> +	  Copyright (C) 2009 Alban Browaeys <prahal@yahoo.com>
>> +	  Copyright (C) 2009 Felix Fietkau <nbd@openwrt.org>
>> +	  Copyright (C) 2009 Luis Correia <luis.f.correia@gmail.com>
>> +	  Copyright (C) 2009 Mattias Nissler <mattias.nissler@gmx.de>
>> +	  Copyright (C) 2009 Mark Asselstine <asselsm@gmail.com>
>> +	  Copyright (C) 2009 Xose Vazquez Perez <xose.vazquez@gmail.com>
>>  	  <http://rt2x00.serialmonkey.com>
>>  
>>  	This program is free software; you can redistribute it and/or modify
> 
> If Bartlomiej has no objections, we could just update the statements for rt2800lib.c/rt2800lib.h
> to something similar as rt2800.h:
> 
> /*
> 	Copyright (C) 2009 Bartlomiej Zolnierkiewicz
> 	Copyright (C) 2009 Ivo van Doorn <IvDoorn@gmail.com>
> 	Copyright (C) 2009 Alban Browaeys <prahal@yahoo.com>
> 	Copyright (C) 2009 Felix Fietkau <nbd@openwrt.org>
> 	Copyright (C) 2009 Luis Correia <luis.f.correia@gmail.com>
> 	Copyright (C) 2009 Mattias Nissler <mattias.nissler@gmx.de>
> 	Copyright (C) 2009 Mark Asselstine <asselsm@gmail.com>
> 	Copyright (C) 2009 Xose Vazquez Perez <xose.vazquez@gmail.com>
> 
> 	This program is free software; you can redistribute it and/or modify
> ....
> 
> because not sure if we need the seperate "based on" comment.. But I'll let Bartlomiej
> decide on this one.
> 
> For the the remaining part:
> 
> Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> 

OK. I'll do the change in rt2800lib as well and resubmit.

---
Gertjan.


  reply	other threads:[~2009-11-08 14:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-08 14:18 [PATCH 7/7] rt2x00: Update copyright statements Gertjan van Wingerde
2009-11-08 14:24 ` Gertjan van Wingerde
2009-11-08 14:25 ` Ivo van Doorn
2009-11-08 14:42   ` Gertjan van Wingerde [this message]
2009-11-08 14:48   ` Bartlomiej Zolnierkiewicz
2009-11-08 14:54     ` Ivo van Doorn
2009-11-08 14:58       ` [rt2x00-users] " Luis Correia
2009-11-08 15:05     ` Gertjan van Wingerde
2009-11-08 15:15       ` Bartlomiej Zolnierkiewicz
2009-11-08 15:27         ` Gertjan van Wingerde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF6D8CB.5090302@gmail.com \
    --to=gwingerde@gmail.com \
    --cc=bzolnier@gmail.com \
    --cc=ivdoorn@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).