Re: [PATCH 7/7] rt2x00: Update copyright statements.

[Gertjan van Wingerde <gwingerde@gmail.com>]

On 11/08/09 15:48, Bartlomiej Zolnierkiewicz wrote:
> On Sunday 08 November 2009 15:25:58 Ivo van Doorn wrote:
> 
>>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
>>> index 5c7d74a..3207b83 100644
>>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
>>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
>>> @@ -3,7 +3,13 @@
>>>  
>>>  	Based on the original rt2800pci.c and rt2800usb.c:
>>>  
>>> -	  Copyright (C) 2004 - 2009 rt2x00 SourceForge Project
>>> +	  Copyright (C) 2009 Ivo van Doorn <IvDoorn@gmail.com>
>>> +	  Copyright (C) 2009 Alban Browaeys <prahal@yahoo.com>
>>> +	  Copyright (C) 2009 Felix Fietkau <nbd@openwrt.org>
>>> +	  Copyright (C) 2009 Luis Correia <luis.f.correia@gmail.com>
>>> +	  Copyright (C) 2009 Mattias Nissler <mattias.nissler@gmx.de>
>>> +	  Copyright (C) 2009 Mark Asselstine <asselsm@gmail.com>
>>> +	  Copyright (C) 2009 Xose Vazquez Perez <xose.vazquez@gmail.com>
>>>  	  <http://rt2x00.serialmonkey.com>
>>>  
>>>  	This program is free software; you can redistribute it and/or modify
>>
>> If Bartlomiej has no objections, we could just update the statements for rt2800lib.c/rt2800lib.h
>> to something similar as rt2800.h:
>>
>> /*
>> 	Copyright (C) 2009 Bartlomiej Zolnierkiewicz
>> 	Copyright (C) 2009 Ivo van Doorn <IvDoorn@gmail.com>
>> 	Copyright (C) 2009 Alban Browaeys <prahal@yahoo.com>
>> 	Copyright (C) 2009 Felix Fietkau <nbd@openwrt.org>
>> 	Copyright (C) 2009 Luis Correia <luis.f.correia@gmail.com>
>> 	Copyright (C) 2009 Mattias Nissler <mattias.nissler@gmx.de>
>> 	Copyright (C) 2009 Mark Asselstine <asselsm@gmail.com>
>> 	Copyright (C) 2009 Xose Vazquez Perez <xose.vazquez@gmail.com>
>>
>> 	This program is free software; you can redistribute it and/or modify
>> ....
>>
>> because not sure if we need the seperate "based on" comment.. But I'll let Bartlomiej
>> decide on this one.
> 
> I think that the original version is correct and also documents new
> development direction well.
> 

To be honest I believe Ivo is right here. The current "based on" way of documenting copyright does seem to suggest that this list of people does not
have any copyright claims to the code in rt2800lib.c. This is not true, as the code is pure copies from their code that was previously in rt2800usb and
rt2800pci. Therefore I believe it is better to have one list of copyright statements.
Obviously we need to preserve the statement that rt2800lib is based on rt2800pci and rt2800usb.

Something like:

 /*                                                                                                      
	Copyright (C) 2009 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>                                
	Copyright (C) 2009 Ivo van Doorn <IvDoorn@gmail.com>                                             
	Copyright (C) 2009 Alban Browaeys <prahal@yahoo.com>                                             
	Copyright (C) 2009 Felix Fietkau <nbd@openwrt.org>                                               
	Copyright (C) 2009 Luis Correia <luis.f.correia@gmail.com>                                       
	Copyright (C) 2009 Mattias Nissler <mattias.nissler@gmx.de>                                      
	Copyright (C) 2009 Mark Asselstine <asselsm@gmail.com>                                           
	Copyright (C) 2009 Xose Vazquez Perez <xose.vazquez@gmail.com>                                   
	<http://rt2x00.serialmonkey.com>                                                                 
                                                                                                
	Based on the original rt2800pci.c and rt2800usb.c.                                               

	This program is free software; you can redistribute it and/or modify
....                                                                      

---
Gertjan.