From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ew0-f207.google.com ([209.85.219.207]:64180 "EHLO mail-ew0-f207.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754815AbZKHTCh (ORCPT ); Sun, 8 Nov 2009 14:02:37 -0500 Received: by ewy3 with SMTP id 3so2528179ewy.37 for ; Sun, 08 Nov 2009 11:02:42 -0800 (PST) Message-ID: <4AF715CF.8090205@gmail.com> Date: Sun, 08 Nov 2009 20:02:39 +0100 From: Gertjan van Wingerde MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz CC: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH] rt2x00: Mark rt2800pci as broken. References: <1257679734-25160-1-git-send-email-gwingerde@gmail.com> <200911081338.34697.bzolnier@gmail.com> <200911081820.18251.bzolnier@gmail.com> In-Reply-To: <200911081820.18251.bzolnier@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/08/09 18:20, Bartlomiej Zolnierkiewicz wrote: > On Sunday 08 November 2009 13:38:34 Bartlomiej Zolnierkiewicz wrote: > >> On Sunday 08 November 2009 12:28:54 Gertjan van Wingerde wrote: >>> The rt2800pci driver is currently only marked as experimental, and only the help text explains that >>> the driver is basically non-functional. Make the driver depend on CONFIG_BROKEN so that users cannot >>> enable this driver without knowing that it is broken. >>> >>> Signed-off-by: Gertjan van Wingerde >> >>> @@ -78,9 +78,6 @@ config RT2800PCI >>> This adds support for rt2800 wireless chipset family. >>> Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890 & RT3052 >>> >>> - This driver is non-functional at the moment and is intended for >>> - developers. >>> - >>> When compiled as a module, this driver will be called "rt2800pci.ko". >>> >>> config RT2500USB >> >> This help text could have stayed, anyway.. >> >> Acked-by: Bartlomiej Zolnierkiewicz > > It turned out that CONFIG_BROKEN is no longer an user visible option so by > applying this change we would lose the advantage of having the upstream build > testing and early detection of breakages related to upstream API updates. > > [ I've just noticed now that rt2800pci was no longer included in the build > and dropped the patch from rt2800 tree. ] > Yeah, I noticed that too. So I guess it is better not to apply it, as we then loose testing coverage. --- Gertjan.