From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Gertjan van Wingerde <gwingerde@gmail.com>
Cc: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org,
Ivo van Doorn <IvDoorn@gmail.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Gertjan van Wingerde <gwingerde@wingerd.gvw.nl>
Subject: Re: [PATCH 6/9] rt2x00: Fix typo in rf programming of rt2800lib.
Date: Mon, 09 Nov 2009 23:01:22 +0100 [thread overview]
Message-ID: <4AF89132.4090508@gmail.com> (raw)
In-Reply-To: <1257803751-5265-1-git-send-email-gwingerde@gmail.com>
On 11/09/09 22:55, Gertjan van Wingerde wrote:
> From: Gertjan van Wingerde <gwingerde@wingerd.gvw.nl>
>
> Fix a type in rt2800_config_channel_rt3x. The second write to RF register 2 should be to RF register 3.
> This is confirmed by the legacy Ralink code.
>
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 24b3af4..2c91c44 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -774,7 +774,7 @@ static void rt2800_config_channel_rt3x(struct rt2x00_dev *rt2x00dev,
> u8 rfcsr;
>
> rt2800_rfcsr_write(rt2x00dev, 2, rf->rf1);
> - rt2800_rfcsr_write(rt2x00dev, 2, rf->rf3);
> + rt2800_rfcsr_write(rt2x00dev, 3, rf->rf3);
>
> rt2800_rfcsr_read(rt2x00dev, 6, &rfcsr);
> rt2x00_set_field8(&rfcsr, RFCSR6_R, rf->rf2);
Please disregard this one. I goofed up the subject of the email again. Will resubmit as a single patch.
---
Gertjan.
prev parent reply other threads:[~2009-11-09 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 21:55 [PATCH 6/9] rt2x00: Fix typo in rf programming of rt2800lib Gertjan van Wingerde
2009-11-09 22:01 ` Gertjan van Wingerde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF89132.4090508@gmail.com \
--to=gwingerde@gmail.com \
--cc=IvDoorn@gmail.com \
--cc=bzolnier@gmail.com \
--cc=gwingerde@wingerd.gvw.nl \
--cc=linux-wireless@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).