From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
IvDoorn@gmail.com, linux-wireless@vger.kernel.org,
users@rt2x00.serialmonkey.com
Subject: Re: [PATCH] rt2x00: fix build of rt2800lib
Date: Mon, 09 Nov 2009 23:24:33 +0100 [thread overview]
Message-ID: <4AF896A1.1000909@gmail.com> (raw)
In-Reply-To: <200911081831.43381.bzolnier@gmail.com>
On 11/08/09 18:31, Bartlomiej Zolnierkiewicz wrote:
> On Sunday 08 November 2009 14:27:38 Hauke Mehrtens wrote:
>> Hi,
>>
>> I am building recent wireless-testing. Without my patch I get the
>> following error while compiling it with CONFIG_RT2800USB=y with
>> CONFIG_RT2800USB=m it compiles fine without any modifications. Looks
>> like there is an other problem and my patch does not fix the real problem.
>
> I've reproduced it here and your patch is fine but it would be better
> if rt2x00usb.h would include <linux/usb.h> itself instead of depending on
> its users (device drivers) but I'll leave this decision up to Ivo/Gartjan.
>
> I've fixed the issue in the patch introducing the problem ("rt2800: add
> rt2800lib (part three)") to preserve bisectability of rt2800usb driver.
>
Actually, including <linux/usb.h> from rt2x00usb.h would be more appropriate.
I'll send a patch for it.
---
Gertjan.
next prev parent reply other threads:[~2009-11-09 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-08 12:07 [PATCH] rt2x00: fix build of rt2800lib Hauke Mehrtens
2009-11-08 12:25 ` Bartlomiej Zolnierkiewicz
2009-11-08 13:27 ` Hauke Mehrtens
2009-11-08 17:31 ` Bartlomiej Zolnierkiewicz
2009-11-09 22:24 ` Gertjan van Wingerde [this message]
2009-11-08 12:37 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF896A1.1000909@gmail.com \
--to=gwingerde@gmail.com \
--cc=IvDoorn@gmail.com \
--cc=bzolnier@gmail.com \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).