From: Larry Finger <Larry.Finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
bzolnier@gmail.com,
Bernhard Schiffner <bernhard@schiffner-limbach.de>,
linux-wireless@vger.kernel.org
Subject: Re: [RFT 6/6] rtl8187se: Modify Kconfig and Makefile
Date: Tue, 10 Nov 2009 09:40:19 -0600 [thread overview]
Message-ID: <4AF98963.7060905@lwfinger.net> (raw)
In-Reply-To: <20091110133407.GA12682@tuxdriver.com>
On 11/10/2009 07:34 AM, John W. Linville wrote:
> On Tue, Nov 10, 2009 at 10:20:55AM +0100, Marcel Holtmann wrote:
>> Hi Larry,
>>
>>> Modify configuration and builod system for rtl8187se.
>>>
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>> ---
>>>
>>> Index: wireless-testing/drivers/net/wireless/Kconfig
>>> ===================================================================
>>> --- wireless-testing.orig/drivers/net/wireless/Kconfig
>>> +++ wireless-testing/drivers/net/wireless/Kconfig
>>> @@ -294,6 +294,16 @@ config RTL8187_LEDS
>>> depends on RTL8187 && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = RTL8187)
>>> default y
>>>
>>> +config RTL8187SE
>>> + tristate "Realtek 8187SE PCI support"
>>> + depends on MAC80211 && PCI && WLAN_80211 && EXPERIMENTAL
>>> + select EEPROM_93CX6
>>> + ---help---
>>> + This is a driver for RTL8187SE PCI-based cards. If built as a
>>> + module, it will be named rtl8187se.
>>> +
>>> + Thanks to Realtek for their support!
>>
>> does this really belong into the help text. Having it in the copyright
>> header seems enough. Especially since this help text is not offering any
>> additional advice or information for the user.
>
> FWIW, I think Larry basically copied that from the other Realtek
> entries. But you are right, it should probably be gone...
That is exactly what happened, but it is gone now.
Larry
prev parent reply other threads:[~2009-11-10 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 23:31 [RFT 6/6] rtl8187se: Modify Kconfig and Makefile Larry Finger
2009-11-10 9:20 ` Marcel Holtmann
2009-11-10 13:34 ` John W. Linville
2009-11-10 15:40 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF98963.7060905@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bernhard@schiffner-limbach.de \
--cc=bzolnier@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).