Re: [PATCH] rt2x00: Initialize rf302x RF values properly in rt2800pci.

[Gertjan van Wingerde <gwingerde@gmail.com>]

On 11/10/09 19:41, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi Gertjan,
> 
> On Monday 09 November 2009 23:00:17 Gertjan van Wingerde wrote:
>> Insert RF chipset values for the RF302x chipsets. Mirrored from the rt2800usb driver.
>> Also, ensure these RF chipsets are handled properly in rt2800lib for the rt3090 chipset.
>>
>> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
>> ---
>>
>> This one clashes with the patch series sent by Bart. However, I believe that logically this patch
>> belongs before his patch series, as it makes the unification cleaner and clearer.
> 
> The change itself is correct and much welcomed but please take a look
> at the diffstat below:
> 
>> ---
>>  drivers/net/wireless/rt2x00/rt2800lib.c |    5 +++--
>>  drivers/net/wireless/rt2x00/rt2800pci.c |   31 +++++++++++++++++++++++++++----
>>  drivers/net/wireless/rt2x00/rt2800usb.c |    8 ++++----
>>  3 files changed, 34 insertions(+), 10 deletions(-)
> 
> I worry that applying this patch before unification will not make anything
> cleaner, especially since it duplicates code that unification patch will now
> have to also remove:
> 

I agree that the patch in itself won't make things cleaner. However, my argument was that applying this
patch before unification would make the unification patch cleaner and clearer (i.e. it would be more
obvious that there is a large degree of overlap).

However, since I am such a nice guy, I will respin my 2 of my patches (the RT3070 detection for rt2800usb
and this one) to apply on top of your patch series.

---
Gertjan.