From: Larry Finger <Larry.Finger@lwfinger.net>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: John W Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH V2] p54usb: Remove DMA buffer from stack
Date: Thu, 12 Nov 2009 10:27:43 -0600 [thread overview]
Message-ID: <4AFC377F.6050507@lwfinger.net> (raw)
In-Reply-To: <200911121051.11982.chunkeey@googlemail.com>
On 11/12/2009 03:51 AM, Christian Lamparter wrote:
> On Thursday 12 November 2009 01:02:29 Larry Finger wrote:
>> On 2.6.32-rc6 from wireless-testing, the following warning is emitted:
>>
>> ------------[ cut here ]------------
>> WARNING: at lib/dma-debug.c:860 check_for_stack+0xaa/0xe0()
>> Hardware name: HP Pavilion dv2700 Notebook PC
>> ehci_hcd 0000:00:02.1: DMA-API: device driver maps memory fromstack
>> [addr=ffff8800b6e2bca8]
-- snip --
>
> Acked-by: Christian Lamparter <chunkeey@googlemail.com>
>
> FYI, p54u_upload_firmware_net2280 will likely produce the same
> same WARN, since "__le32 reg;" is held on the stack as well.
I was pretty certain that the WARN is only for DMA buffers on the stack. After
reviewing the code lib/dma-debug.c, nothing changed my mind. In
p54u_upload_firmware_net2280, the buffer is kmalloc'ed already. It should be OK.
Larry
prev parent reply other threads:[~2009-11-12 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 0:02 [PATCH V2] p54usb: Remove DMA buffer from stack Larry Finger
2009-11-12 9:51 ` Christian Lamparter
2009-11-12 16:27 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFC377F.6050507@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).