Re: [PATCH 1/2] mac80211: add private driver flags and ampdu length to tx info

[Felix Fietkau <nbd@openwrt.org>]

Johannes Berg wrote:
> On Sat, 2009-11-14 at 17:05 +0100, Felix Fietkau wrote:
> 
>> - * @ampdu_ack_len: number of aggregated frames.
>> - * 	relevant only if IEEE80211_TX_STATUS_AMPDU was set.
>> + * @ampdu_ack_len: number of acked aggregated frames.
>> + * 	relevant only if ieee80211_tx_status_ampdu was set.
> 
> why lowercase that?
Sorry, late night vim accident. I'll resend...

>> -	/* 2 byte hole */
>> -	u8 pad[2];
>> +	u8 driver_flags;
>> +	u8 pad;
> 
> The ampdu_len seems ok, but I'm still not convinced this is right.
> Drivers _should_ have enough space in the driver parts of this struct,
> and not need flags here. I realise that you do need that because of the
> RC and other internal things, but maybe you could simply use "pad[0]"
> for that so not to encourage others to start doing this too?
If you prefer it using the padding directly, I can change it to that
too. I don't mind as long as I have space to put that stuff into and
don't need to use rate_driver_data.

- Felix