* [PATCH] staging: rtl8187se: Rename staging driver to avoid name conflict with mainline driver
@ 2009-11-16 14:57 Larry Finger
2009-11-16 20:02 ` Gábor Stefanik
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2009-11-16 14:57 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, linux-wireless
Now that active development has begun on a mainline version of
a driver for the RTL8187SE that should be called rtl8187se, there
is a conflict with the driver in staging with the same name.
To solve the conflict, rename the driver in staging to rtl8187se_stage.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Index: wireless-testing/drivers/staging/Makefile
===================================================================
--- wireless-testing.orig/drivers/staging/Makefile
+++ wireless-testing/drivers/staging/Makefile
@@ -20,7 +20,7 @@ obj-$(CONFIG_COMEDI) += comedi/
obj-$(CONFIG_ASUS_OLED) += asus_oled/
obj-$(CONFIG_PANEL) += panel/
obj-$(CONFIG_ALTERA_PCIE_CHDMA) += altpciechdma/
-obj-$(CONFIG_RTL8187SE) += rtl8187se/
+obj-$(CONFIG_RTL8187SE_STAGE) += rtl8187se/
obj-$(CONFIG_RTL8192SU) += rtl8192su/
obj-$(CONFIG_RTL8192E) += rtl8192e/
obj-$(CONFIG_INPUT_MIMIO) += mimio/
Index: wireless-testing/drivers/staging/rtl8187se/Kconfig
===================================================================
--- wireless-testing.orig/drivers/staging/rtl8187se/Kconfig
+++ wireless-testing/drivers/staging/rtl8187se/Kconfig
@@ -1,4 +1,4 @@
-config RTL8187SE
+config RTL8187SE_STAGE
tristate "RealTek RTL8187SE Wireless LAN NIC driver"
depends on PCI && WLAN
select WIRELESS_EXT
Index: wireless-testing/drivers/staging/rtl8187se/Makefile
===================================================================
--- wireless-testing.orig/drivers/staging/rtl8187se/Makefile
+++ wireless-testing/drivers/staging/rtl8187se/Makefile
@@ -16,7 +16,7 @@ EXTRA_CFLAGS += -DENABLE_LPS
#EXTRA_CFLAGS += -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y
-rtl8187se-objs := \
+rtl8187se_stage-objs := \
r8180_core.o \
r8180_93cx6.o \
r8180_wx.o \
@@ -35,5 +35,5 @@ rtl8187se-objs := \
ieee80211/ieee80211_crypt_ccmp.o \
ieee80211/ieee80211_crypt_wep.o
-obj-$(CONFIG_RTL8187SE) += rtl8187se.o
+obj-$(CONFIG_RTL8187SE_STAGE) += rtl8187se_stage.o
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: rtl8187se: Rename staging driver to avoid name conflict with mainline driver
2009-11-16 14:57 [PATCH] staging: rtl8187se: Rename staging driver to avoid name conflict with mainline driver Larry Finger
@ 2009-11-16 20:02 ` Gábor Stefanik
2009-11-16 22:09 ` Larry Finger
0 siblings, 1 reply; 5+ messages in thread
From: Gábor Stefanik @ 2009-11-16 20:02 UTC (permalink / raw)
To: Larry Finger; +Cc: Greg Kroah-Hartman, linux-kernel, linux-wireless
On Mon, Nov 16, 2009 at 3:57 PM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Now that active development has begun on a mainline version of
> a driver for the RTL8187SE that should be called rtl8187se, there
> is a conflict with the driver in staging with the same name.
>
> To solve the conflict, rename the driver in staging to rtl8187se_stage.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> Index: wireless-testing/drivers/staging/Makefile
> ===================================================================
> --- wireless-testing.orig/drivers/staging/Makefile
> +++ wireless-testing/drivers/staging/Makefile
> @@ -20,7 +20,7 @@ obj-$(CONFIG_COMEDI) += comedi/
> obj-$(CONFIG_ASUS_OLED) += asus_oled/
> obj-$(CONFIG_PANEL) += panel/
> obj-$(CONFIG_ALTERA_PCIE_CHDMA) += altpciechdma/
> -obj-$(CONFIG_RTL8187SE) += rtl8187se/
> +obj-$(CONFIG_RTL8187SE_STAGE) += rtl8187se/
> obj-$(CONFIG_RTL8192SU) += rtl8192su/
> obj-$(CONFIG_RTL8192E) += rtl8192e/
> obj-$(CONFIG_INPUT_MIMIO) += mimio/
> Index: wireless-testing/drivers/staging/rtl8187se/Kconfig
> ===================================================================
> --- wireless-testing.orig/drivers/staging/rtl8187se/Kconfig
> +++ wireless-testing/drivers/staging/rtl8187se/Kconfig
> @@ -1,4 +1,4 @@
> -config RTL8187SE
> +config RTL8187SE_STAGE
> tristate "RealTek RTL8187SE Wireless LAN NIC driver"
> depends on PCI && WLAN
> select WIRELESS_EXT
> Index: wireless-testing/drivers/staging/rtl8187se/Makefile
> ===================================================================
> --- wireless-testing.orig/drivers/staging/rtl8187se/Makefile
> +++ wireless-testing/drivers/staging/rtl8187se/Makefile
> @@ -16,7 +16,7 @@ EXTRA_CFLAGS += -DENABLE_LPS
>
> #EXTRA_CFLAGS += -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y
>
> -rtl8187se-objs := \
> +rtl8187se_stage-objs := \
> r8180_core.o \
> r8180_93cx6.o \
> r8180_wx.o \
> @@ -35,5 +35,5 @@ rtl8187se-objs := \
> ieee80211/ieee80211_crypt_ccmp.o \
> ieee80211/ieee80211_crypt_wep.o
>
> -obj-$(CONFIG_RTL8187SE) += rtl8187se.o
> +obj-$(CONFIG_RTL8187SE_STAGE) += rtl8187se_stage.o
Please make this r8187se.o, to be consistent with the other
r8180-sa2400 derivative drivers.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: rtl8187se: Rename staging driver to avoid name conflict with mainline driver
2009-11-16 20:02 ` Gábor Stefanik
@ 2009-11-16 22:09 ` Larry Finger
2009-11-16 22:22 ` John W. Linville
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2009-11-16 22:09 UTC (permalink / raw)
To: Gábor Stefanik; +Cc: Greg Kroah-Hartman, linux-kernel, linux-wireless
On 11/16/2009 02:02 PM, Gábor Stefanik wrote:
>>
>> -obj-$(CONFIG_RTL8187SE) += rtl8187se.o
>> +obj-$(CONFIG_RTL8187SE_STAGE) += rtl8187se_stage.o
>
> Please make this r8187se.o, to be consistent with the other
> r8180-sa2400 derivative drivers.
I cannot do that. From what I see, the kernel make system creates the .ko file
from the name specified here. When I make that rtl8187se.o, then I get
rtl8187se.ko, which is what I want to avoid.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: rtl8187se: Rename staging driver to avoid name conflict with mainline driver
2009-11-16 22:09 ` Larry Finger
@ 2009-11-16 22:22 ` John W. Linville
2009-11-17 0:17 ` Larry Finger
0 siblings, 1 reply; 5+ messages in thread
From: John W. Linville @ 2009-11-16 22:22 UTC (permalink / raw)
To: Larry Finger
Cc: Gábor Stefanik, Greg Kroah-Hartman, linux-kernel,
linux-wireless
On Mon, Nov 16, 2009 at 04:09:33PM -0600, Larry Finger wrote:
> On 11/16/2009 02:02 PM, Gábor Stefanik wrote:
> >>
> >> -obj-$(CONFIG_RTL8187SE) += rtl8187se.o
> >> +obj-$(CONFIG_RTL8187SE_STAGE) += rtl8187se_stage.o
> >
> > Please make this r8187se.o, to be consistent with the other
> > r8180-sa2400 derivative drivers.
>
> I cannot do that. From what I see, the kernel make system creates the .ko file
> from the name specified here. When I make that rtl8187se.o, then I get
> rtl8187se.ko, which is what I want to avoid.
Gábor is suggesting r{no t}{no l}8187se... :-)
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging: rtl8187se: Rename staging driver to avoid name conflict with mainline driver
2009-11-16 22:22 ` John W. Linville
@ 2009-11-17 0:17 ` Larry Finger
0 siblings, 0 replies; 5+ messages in thread
From: Larry Finger @ 2009-11-17 0:17 UTC (permalink / raw)
To: John W. Linville
Cc: Gábor Stefanik, Greg Kroah-Hartman, linux-kernel,
linux-wireless
On 11/16/2009 04:22 PM, John W. Linville wrote:
> On Mon, Nov 16, 2009 at 04:09:33PM -0600, Larry Finger wrote:
>> On 11/16/2009 02:02 PM, Gábor Stefanik wrote:
>>>>
>>>> -obj-$(CONFIG_RTL8187SE) += rtl8187se.o
>>>> +obj-$(CONFIG_RTL8187SE_STAGE) += rtl8187se_stage.o
>>>
>>> Please make this r8187se.o, to be consistent with the other
>>> r8180-sa2400 derivative drivers.
>>
>> I cannot do that. From what I see, the kernel make system creates the .ko file
>> from the name specified here. When I make that rtl8187se.o, then I get
>> rtl8187se.ko, which is what I want to avoid.
>
> Gábor is suggesting r{no t}{no l}8187se... :-)
Thanks for making that clear - I completely misinterpreted the request.
Apologies to Gábor.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-11-17 0:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-16 14:57 [PATCH] staging: rtl8187se: Rename staging driver to avoid name conflict with mainline driver Larry Finger
2009-11-16 20:02 ` Gábor Stefanik
2009-11-16 22:09 ` Larry Finger
2009-11-16 22:22 ` John W. Linville
2009-11-17 0:17 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).