From: Felix Fietkau <nbd@openwrt.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>
Subject: Re: [PATCH v2 1/2] ath9k: properly use the mac80211 rate control api
Date: Wed, 18 Nov 2009 16:36:46 +0100 [thread overview]
Message-ID: <4B04148E.6010202@openwrt.org> (raw)
In-Reply-To: <20091118152909.GC2911@tuxdriver.com>
John W. Linville wrote:
> On Wed, Nov 18, 2009 at 05:30:57AM +0100, Felix Fietkau wrote:
>> This patch changes ath9k to pass proper MCS indexes and flags
>> between the RC and the rest of the driver code.
>> sc->cur_rate_table remains, as it's used by the RC code internally,
>> but the rest of the driver code no longer uses it, so a potential
>> new RC for ath9k would not have to update it.
>>
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>> ---
>> - replaces sc->hw usage with common->hw
>> - initializes unused tx status rates to -1 for minstrel compatibility
>> - split up for easier review
>> - tested in ap mode with minstrel against a legacy STA
>> - v2: fix bisectability
>
> CC [M] drivers/net/wireless/ath/ath9k/rc.o
> drivers/net/wireless/ath/ath9k/rc.c: In function ‘ath_tx_status’:
> drivers/net/wireless/ath/ath9k/rc.c:1272: warning: passing argument 2 of ‘ath_debug_stat_rc’ makes pointer from integer without a cast
> drivers/net/wireless/ath/ath9k/debug.h:173: note: expected ‘struct sk_buff *’ but argument is of type ‘int’
Sorry, I must have lost a patch chunk there. Will fix it later.
- Felix
prev parent reply other threads:[~2009-11-18 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 4:30 [PATCH v2 1/2] ath9k: properly use the mac80211 rate control api Felix Fietkau
2009-11-18 4:32 ` [PATCH v2 2/2] ath9k: clean up rc rate table Felix Fietkau
2009-11-18 15:29 ` [PATCH v2 1/2] ath9k: properly use the mac80211 rate control api John W. Linville
2009-11-18 15:36 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B04148E.6010202@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).