From: Larry Finger <Larry.Finger@lwfinger.net>
To: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Cc: Michael Buesch <mb@bu3sch.de>,
John W Linville <linville@tuxdriver.com>,
Hin-Tak Leung <htl10@users.sourceforge.net>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC/RFT] rtl8187: Fix 'queuing ieee80211 work while going to suspend' warning
Date: Tue, 08 Dec 2009 14:16:59 -0600 [thread overview]
Message-ID: <4B1EB43B.8090806@lwfinger.net> (raw)
In-Reply-To: <200912081341.20682.herton@mandriva.com.br>
On 12/08/2009 09:41 AM, Herton Ronaldo Krzesinski wrote:
> That's why in my last patch I added code to register the radio led, we have to
> go that way to fix properly the issue (also this way we turn the led on/off only
> when mac80211 wants it, which is the right way), so we can avoid having to
> place code in start/stop or creating suspend/resume hooks only because the
> issue.
I do not understand the reason for adding another LED device, nor why
you think it helps. When I added the LED code, I wanted to get the LED
to indicate that there was I/O activity, which is why I chose the TX
and RX LEDs. Choosing "on" as the default state when there was no
activity and blinking it "off" with I/O seems to give exactly the
right behavior. Unfortunately, the asynchronous behavior of the USB
operations makes it very tricky to get the shutdown right.
Larry
next prev parent reply other threads:[~2009-12-08 20:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 2:08 [RFC/RFT] rtl8187: Fix 'queuing ieee80211 work while going to suspend' warning Larry Finger
2009-12-08 11:02 ` Michael Buesch
2009-12-08 15:41 ` Larry Finger
2009-12-08 15:41 ` Herton Ronaldo Krzesinski
2009-12-08 20:16 ` Larry Finger [this message]
2009-12-08 20:57 ` Herton Ronaldo Krzesinski
2009-12-08 21:00 ` Larry Finger
2009-12-08 21:07 ` Herton Ronaldo Krzesinski
2009-12-08 22:18 ` Hin-Tak Leung
2009-12-08 22:23 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1EB43B.8090806@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=herton@mandriva.com.br \
--cc=htl10@users.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).