From: Jiri Slaby <jirislaby@gmail.com>
To: Sujith <Sujith.Manoharan@atheros.com>,
Vasanthakumar Thiagarajan <vasanth@atheros.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>
Subject: useless ath9k commit logs
Date: Wed, 09 Dec 2009 11:07:46 +0100 [thread overview]
Message-ID: <4B1F76F2.4090004@gmail.com> (raw)
Hi Sujith and Vasanthakumar,
could I ask you to ever explain why your ath9k patches are needed? Your
commit logs often describe the change, but not why you are doing that
(e.g. what exact issue it fixes). This is hard for us to decide whether
it should be backported to distro kernels or not.
For example
ath9k: Fix bug in ANI channel handling
When processing MIB interrupts, OFDM and CCK error
handling routines for low RSSI values have to be invoked
only when the channel mode is 11G/11B. Since HT channels
will also fall under the bands 2Ghz/5Ghz, check appropriately.
or
ath9k: Maintain monotonicity of PER while going across different phy
Monotonicity of packet error rate should be kept when moving
from one phy to another (legacy to ht, ht single stream to dual,
etc). Current code skips updating per for other phys.
I don't know from that, what bug, under what circumstanses these fix. If
any -- e.g. a theoretical issue.
thanks,
--
js
next reply other threads:[~2009-12-09 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 10:07 Jiri Slaby [this message]
2009-12-09 11:35 ` useless ath9k commit logs Sujith
2009-12-09 12:05 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1F76F2.4090004@gmail.com \
--to=jirislaby@gmail.com \
--cc=Sujith.Manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vasanth@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).