linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave <kilroyd@googlemail.com>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Cc: orinoco-devel@lists.sourceforge.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] orinoco: fix GFP_KERNEL in orinoco_set_key with interrupts disabled
Date: Thu, 10 Dec 2009 18:34:53 +0000	[thread overview]
Message-ID: <4B213F4D.2000707@gmail.com> (raw)
In-Reply-To: <200912101955.01325.arvidjaar@mail.ru>

Andrey Borzenkov wrote:
> I had to resurrect old notebook and immediately hit this under 2.6.32:
> 
> [   77.254109] WARNING: at /home/bor/src/linux-git/kernel/lockdep.c:2465 
> lockdep
> _trace_alloc+0x9a/0xa0()
> 
> Until orinoco_lock can be converted from spinlock into mutex, this patch 
> is the most simple solution.

Thank you Andrey. The patch is correct (though it could clean up the
misdirected comment 4 or 5 lines above).

Is it worth pushing this to stable?


Dave.

  reply	other threads:[~2009-12-10 18:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-10 16:54 [PATCH] orinoco: fix GFP_KERNEL in orinoco_set_key with interrupts disabled Andrey Borzenkov
2009-12-10 18:34 ` Dave [this message]
2009-12-10 18:55   ` Andrey Borzenkov
2009-12-14 13:53     ` Dave
2009-12-22 18:38       ` [PATCH v2] 2.6.33: " Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B213F4D.2000707@gmail.com \
    --to=kilroyd@googlemail.com \
    --cc=arvidjaar@mail.ru \
    --cc=linux-wireless@vger.kernel.org \
    --cc=orinoco-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).