linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benoit PAPILLAULT <benoit.papillault@free.fr>
To: rt2x00 Users List <users@rt2x00.serialmonkey.com>
Cc: Ivo van Doorn <ivdoorn@gmail.com>,
	stable@kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [rt2x00-users] [PATCH 2.6.33] rt2x00: Disable powersaving for rt61pci.
Date: Sun, 13 Dec 2009 16:45:05 +0100	[thread overview]
Message-ID: <4B250C01.4050400@free.fr> (raw)
In-Reply-To: <4B25068E.7000201@gmail.com>

Gertjan van Wingerde a écrit :
> On 12/13/09 16:18, Ivo van Doorn wrote:
>> On Sunday 13 December 2009, Gertjan van Wingerde wrote:
>>> On 12/13/09 11:15, Ivo van Doorn wrote:
>>>> On Sunday 13 December 2009, Gertjan van Wingerde wrote:
>>>>> We've had many reports of rt61pci failures with powersaving enabled.
>>>>> Therefore, as a stop-gap measure, disable powersaving of the rt61pci
>>>>> until we have found a proper solution.
>>>> This disables powersaving completely, can't we set the default powersaving
>>>> to disabled? That way for people for who it does work, it can still be enabled.
>>>>
>>> Well, when I was looking into this I came up with a number of issues in the code
>>> which makes me believe that it simply isn't working at all.
>>> One example is that the rt61pci devices rely on handling the wakeup interrupt
>>> by the driver to wake up the devices. As far as I can tell there is no handling
>>> of the wakeup interrupt in the rt61pci driver.
>>> That's why I decided to disable it all together, as I don't think it works
>>> properly for anyone (although some people may not really notice it).
>> Ok, but then please disable it for _all_ rt2x00 drivers, or at least all PCI rt2x00 drivers
>> since they would have the same wakeup interrupt requirement.
>>
> 
> I'll see if this will be the case for all PCI rt2x00 devices and adapt for the ones that
> need it. I didn't look into the other devices yet, and ISTR that at least rt2500pci doesn't
> have this requirement.
> 
> ---
> Gertjan.

If the same mecanism is used by rt2800usb, that would explain why power save is
not working as well on my rt2870 USB device. Is there a way to start the device
with power save disabled at startup (so it can be reenabled later to debug it).

Regards,
Benoit

  reply	other threads:[~2009-12-13 15:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-12 23:39 [PATCH 2.6.33] rt2x00: Fix rt2800usb detection in rt2800lib Gertjan van Wingerde
2009-12-12 23:39 ` [PATCH 2.6.33] rt2x00: Disable powersaving for rt61pci Gertjan van Wingerde
2009-12-13 10:15   ` Ivo van Doorn
2009-12-13 15:16     ` Gertjan van Wingerde
2009-12-13 15:18       ` Ivo van Doorn
2009-12-13 15:21         ` Gertjan van Wingerde
2009-12-13 15:45           ` Benoit PAPILLAULT [this message]
2009-12-14 19:27           ` Gertjan van Wingerde
2009-12-13  3:54 ` [PATCH 2.6.33] rt2x00: Fix rt2800usb detection in rt2800lib Randy Dunlap
2009-12-13 10:14 ` Ivo van Doorn
2009-12-14 19:13 ` [PATCH] " John W. Linville
2009-12-14 19:24   ` Gertjan van Wingerde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B250C01.4050400@free.fr \
    --to=benoit.papillault@free.fr \
    --cc=ivdoorn@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).